linux-kernel - Re: [PATCH 1/2] afs: Fix ignored callbacks over ipv4

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZdOHaTLPkV8VlU7x@casper.infradead.org>
Date: Mon, 19 Feb 2024 16:52:57 +0000
From: Matthew Wilcox <willy@...radead.org>
To: David Howells <dhowells@...hat.com>
Cc: Christian Brauner <christian@...uner.io>,
	Markus Suvanto <markus.suvanto@...il.com>,
	Marc Dionne <marc.dionne@...istor.com>,
	Daniil Dulov <d.dulov@...ddin.ru>, linux-afs@...ts.infradead.org,
	linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] afs: Fix ignored callbacks over ipv4

On Mon, Feb 19, 2024 at 02:39:02PM +0000, David Howells wrote:
> +++ b/fs/afs/internal.h
> @@ -321,8 +321,7 @@ struct afs_net {
>  	struct list_head	fs_probe_slow;	/* List of afs_server to probe at 5m intervals */
>  	struct hlist_head	fs_proc;	/* procfs servers list */
>  
> -	struct hlist_head	fs_addresses4;	/* afs_server (by lowest IPv4 addr) */
> -	struct hlist_head	fs_addresses6;	/* afs_server (by lowest IPv6 addr) */
> +	struct hlist_head	fs_addresses;	/* afs_server (by lowest IPv6 addr) */

Comment is out of date ...

> @@ -561,8 +560,7 @@ struct afs_server {
>  	struct afs_server __rcu	*uuid_next;	/* Next server with same UUID */
>  	struct afs_server	*uuid_prev;	/* Previous server with same UUID */
>  	struct list_head	probe_link;	/* Link in net->fs_probe_list */
> -	struct hlist_node	addr4_link;	/* Link in net->fs_addresses4 */
> -	struct hlist_node	addr6_link;	/* Link in net->fs_addresses6 */
> +	struct hlist_node	addr_link;	/* Link in net->fs_addresses6 */

Ditto