linux-kernel - Re: [PATCH v17 3/6] tracing: Add snapshot refcount

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Mon, 19 Feb 2024 13:22:54 -0500
From: Steven Rostedt <rostedt@...dmis.org>
To: Vincent Donnefort <vdonnefort@...gle.com>
Cc: mhiramat@...nel.org, linux-kernel@...r.kernel.org,
 linux-trace-kernel@...r.kernel.org, mathieu.desnoyers@...icios.com,
 kernel-team@...roid.com
Subject: Re: [PATCH v17 3/6] tracing: Add snapshot refcount

On Mon, 19 Feb 2024 13:17:54 -0500
Steven Rostedt <rostedt@...dmis.org> wrote:

> On Tue, 13 Feb 2024 11:49:42 +0000
> Vincent Donnefort <vdonnefort@...gle.com> wrote:
> 
> > @@ -9678,7 +9739,9 @@ trace_array_create_systems(const char *name, const char *systems)
> >  	raw_spin_lock_init(&tr->start_lock);
> >  
> >  	tr->max_lock = (arch_spinlock_t)__ARCH_SPIN_LOCK_UNLOCKED;
> > -
> > +#ifdef CONFIG_TRCER_MAX_TRACE  
> 
> Oops!
> 
> I'll fix this too.
> 
> 
> > +	spinlock_init(&tr->snapshot_trigger_lock);

And this too:

kernel/trace/trace.c:9245:9: error: implicit declaration of function ‘spinlock_init’; did you mean ‘spin_lock_init’? [-Werror=implicit-function-declaration]
 9245 |         spinlock_init(&tr->snapshot_trigger_lock);
      |         ^~~~~~~~~~~~~

-- Steve

> > +#endif
> >  	tr->current_trace = &nop_trace;
> >  
> >  	INIT_LIST_HEAD(&tr->systems);