linux-kernel - RE: [PATCH v3] ata: ahci_ceva: fix error handling for Xilinx GT PHY support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <MN0PR12MB59537A9F0EAEAC9E844C8DCDB7512@MN0PR12MB5953.namprd12.prod.outlook.com>
Date: Mon, 19 Feb 2024 18:42:49 +0000
From: "Pandey, Radhey Shyam" <radhey.shyam.pandey@....com>
To: Markus Elfring <Markus.Elfring@....de>, Niklas Cassel <cassel@...nel.org>,
	Damien Le Moal <dlemoal@...nel.org>, Jens Axboe <axboe@...nel.dk>, "Simek,
 Michal" <michal.simek@....com>, Philipp Zabel <p.zabel@...gutronix.de>,
	"linux-ide@...r.kernel.org" <linux-ide@...r.kernel.org>,
	"kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>
CC: LKML <linux-kernel@...r.kernel.org>, "git (AMD-Xilinx)" <git@....com>
Subject: RE: [PATCH v3] ata: ahci_ceva: fix error handling for Xilinx GT PHY
 support

> -----Original Message-----
> From: Markus Elfring <Markus.Elfring@....de>
> Sent: Monday, February 19, 2024 9:27 PM
> To: Niklas Cassel <cassel@...nel.org>; Pandey, Radhey Shyam
> <radhey.shyam.pandey@....com>; Damien Le Moal
> <dlemoal@...nel.org>; Jens Axboe <axboe@...nel.dk>; Simek, Michal
> <michal.simek@....com>; Philipp Zabel <p.zabel@...gutronix.de>; linux-
> ide@...r.kernel.org; kernel-janitors@...r.kernel.org
> Cc: LKML <linux-kernel@...r.kernel.org>; git (AMD-Xilinx) <git@....com>
> Subject: Re: [PATCH v3] ata: ahci_ceva: fix error handling for Xilinx GT PHY
> support
> 
> > > Platform clock and phy error resources are not cleaned up in Xilinx GT
> PHY
> > > error path.
> > >
> > > To fix introduce the function ceva_ahci_platform_enable_resources()
> …
> > Applied:
> >
> https://git.kernel.org/pub/scm/linux/kernel/git/libata/linux.git/log/?h=for-
> 6.8-fixes
> 
> The error code “-EINVAL” was set before the statement “goto
> disable_resources”
> multiple times in the adjusted implementation of the function
> “ceva_ahci_probe”.
> I suggest to add a jump target so that a bit of exception handling
> can be better reused at the end of this function.
> 
> 
> How do you think about to apply the following script for the semantic
> patch language (Coccinelle software) accordingly?
> 
> 
> @replacement1@
> identifier rc;
> @@
>  <+...
>  if (...)
>  {
>     ... when != rc
> -   rc = -EINVAL;
>     goto
> -        disable_resources
> +        e_inval
>     ;
>  }
>  ...+>
>  return 0;
> +
> +e_inval:
> +rc = -EINVAL;
>  disable_resources:
>  ahci_platform_disable_resources(hpriv);
> 
> @replacement2 disable neg_if, drop_else@
> identifier replacement1.rc;
> statement is;
> @@
>  if (...)
>     is
>  else
>  {
>     ... when != rc
> -   rc = -EINVAL;
>     goto
> -        disable_resources
> +        e_inval
>     ;
>  }
> 
> 
Thanks for the suggestion. However, taking a look at the existing implementation
i think we should return error code *as is * from of_property_read() APIs.
and get rid of rc=-EINVAL reassignment itself. 

If it sounds ok, I can add it to my to-do list and send out a patch.

Thanks,
Radhey