linux-kernel - Re: [PATCH] Staging: vc04_services: bcm2835-camera: fixed several brace coding style checks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8fe8c4bf-5fa3-4bfc-9535-b48df12f80ff@moroto.mountain>
Date: Mon, 19 Feb 2024 09:39:35 +0300
From: Dan Carpenter <dan.carpenter@...aro.org>
To: "Moritz C. Weber" <mo.c.weber@...il.com>
Cc: florian.fainelli@...adcom.com, linux-staging@...ts.linux.dev,
	linux-rpi-kernel@...ts.infradead.org,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Staging: vc04_services: bcm2835-camera: fixed several
 brace coding style checks

On Thu, Feb 15, 2024 at 11:06:47PM +0100, Moritz C. Weber wrote:
> @@ -406,12 +405,11 @@ static void buffer_cb(struct vchiq_mmal_instance *instance,
>  	    is_capturing(dev)) {
>  		v4l2_dbg(1, bcm2835_v4l2_debug, &dev->v4l2_dev,
>  			 "Grab another frame as buffer has EOS");
> -		vchiq_mmal_port_parameter_set(
> -			instance,
> -			dev->capture.camera_port,
> -			MMAL_PARAMETER_CAPTURE,
> -			&dev->capture.frame_count,
> -			sizeof(dev->capture.frame_count));
> +		vchiq_mmal_port_parameter_set(instance,
> +					      dev->capture.camera_port,
> +					      MMAL_PARAMETER_CAPTURE,
> +					      #N(#O(#O(#O(#O(&dev->capture.frame_count,
                                              ^^^^^^^^^^^^^^^^

Wut?

> +					      sizeof(dev->capture.frame_count));
>  	}
>  }
>  
> @@ -420,11 +418,11 @@ static int enable_camera(struct bcm2835_mmal_dev *dev)
>  	int ret;
>  
>  	if (!dev->camera_use_count) {
> -		ret = vchiq_mmal_port_parameter_set(
> -			dev->instance,
> -			&dev->component[COMP_CAMERA]->control,
> -			MMAL_PARAMETER_CAMERA_NUM, &dev->camera_num,
> -			sizeof(dev->camera_num));
> +		ret = vchiq_mmal_port_parameter_set(dev->instance,
> +						    &dev->component[COMP_CAMERA]->control,
> +						    MMAL_PARAMETER_CAMERA_NUM,
> +						    &dev->camera_num,
> +						    **sizeof(dev->camera_num));

Also Wut???


regards,
dan carpenter