linux-kernel - Re: [RESEND PATCH v2] iio: gts-helper: Fix division loop

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f1511679-0309-4aa6-bbfe-40d0d3374634@gmail.com>
Date: Mon, 19 Feb 2024 09:22:24 +0200
From: Matti Vaittinen <mazziesaccount@...il.com>
To: Subhajit Ghosh <subhajit.ghosh@...aklogic.com>,
 Jonathan Cameron <jic23@...nel.org>
Cc: Matti Vaittinen <matti.vaittinen@...rohmeurope.com>,
 Lars-Peter Clausen <lars@...afoo.de>, linux-kernel@...r.kernel.org,
 David Laight <David.Laight@...lab.com>, linux-iio@...r.kernel.org
Subject: Re: [RESEND PATCH v2] iio: gts-helper: Fix division loop

On 2/18/24 07:26, Subhajit Ghosh wrote:
> On 18/2/24 02:57, Jonathan Cameron wrote:
>> On Sun, 18 Feb 2024 01:09:33 +1030
>> Subhajit Ghosh <subhajit.ghosh@...aklogic.com> wrote:
>>
>>> On 17/2/24 00:28, Jonathan Cameron wrote:
>>>> On Mon, 12 Feb 2024 13:20:09 +0200
>>>> Matti Vaittinen <mazziesaccount@...il.com> wrote:
>>>>> The loop based 64bit division may run for a long time when dividend 
>>>>> is a
>>>>> lot bigger than the divider. Replace the division loop by the
>>>>> div64_u64() which implementation may be significantly faster.
>>>>>
>>>>> Signed-off-by: Matti Vaittinen <mazziesaccount@...il.com>
>>>>> Fixes: 38416c28e168 ("iio: light: Add gain-time-scale helpers")
>>>>>
>>>>> ---


> As I understand that you have already applied this patch but still,
> 
> Tested-by: Subhajit Ghosh <subhajit.ghosh@...aklogic.com>

Thank you Subhajit! Your effort is _very much_ appreciated! :)

Yours,
	-- Matti

-- 
Matti Vaittinen
Linux kernel developer at ROHM Semiconductors
Oulu Finland

~~ When things go utterly wrong vim users can always type :help! ~~