linux-kernel - Re: [PATCH for-next] RDMA/hns: Fix mis-modifying default congestion control algorithm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <170832906579.134605.15025302107615338247.b4-ty@kernel.org>
Date: Mon, 19 Feb 2024 09:51:05 +0200
From: Leon Romanovsky <leon@...nel.org>
To: jgg@...pe.ca, Junxian Huang <huangjunxian6@...ilicon.com>
Cc:
 linux-rdma@...r.kernel.org, linuxarm@...wei.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH for-next] RDMA/hns: Fix mis-modifying default congestion
 control algorithm


On Mon, 19 Feb 2024 14:18:05 +0800, Junxian Huang wrote:
> Commit 27c5fd271d8b ("RDMA/hns: The UD mode can only be configured
> with DCQCN") adds a check of congest control alorithm for UD. But
> that patch causes a problem: hr_dev->caps.congest_type is global,
> used by all QPs, so modifying this field to DCQCN for UD QPs causes
> other QPs unable to use any other algorithm except DCQCN.
> 
> Revert the modification in commit 27c5fd271d8b ("RDMA/hns: The UD
> mode can only be configured with DCQCN"). Add a new field cong_type
> to struct hns_roce_qp and configure DCQCN for UD QPs.
> 
> [...]

Applied, thanks!

[1/1] RDMA/hns: Fix mis-modifying default congestion control algorithm
      https://git.kernel.org/rdma/rdma/c/d20a7cf9f714f0

Best regards,
-- 
Leon Romanovsky <leon@...nel.org>