linux-kernel - Re: [PATCH 1/2] sched/topology: loop properly when clearing flags

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAKfTPtAvcRvdHQ2OY4cej26dXt_y5LbtYh=OGWxfbQunh-Juww@mail.gmail.com>
Date: Mon, 19 Feb 2024 09:13:44 +0100
From: Vincent Guittot <vincent.guittot@...aro.org>
To: Michał Mirosław <mirq-linux@...e.qmqm.pl>
Cc: Ingo Molnar <mingo@...hat.com>, Peter Zijlstra <peterz@...radead.org>, 
	Juri Lelli <juri.lelli@...hat.com>, Dietmar Eggemann <dietmar.eggemann@....com>, 
	Steven Rostedt <rostedt@...dmis.org>, Ben Segall <bsegall@...gle.com>, Mel Gorman <mgorman@...e.de>, 
	Daniel Bristot de Oliveira <bristot@...hat.com>, Valentin Schneider <vschneid@...hat.com>, 
	Len Brown <len.brown@...el.com>, "Joel Fernandes (Google)" <joel@...lfernandes.org>, 
	Ricardo Neri <ricardo.neri-calderon@...ux.intel.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] sched/topology: loop properly when clearing flags

On Fri, 16 Feb 2024 at 22:55, Michał Mirosław <mirq-linux@...e.qmqm.pl> wrote:
>
> Fixed commit introduced sched_group::flags and a loop that was supposed
> to clear groups' flags if the child sched_domain was deleted.  The
> iterating part was missing.
>
> Fixes: 16d364ba6ef2 ("sched/topology: Introduce sched_group::flags")
> Signed-off-by: Michał Mirosław <mirq-linux@...e.qmqm.pl>
> ---
>  kernel/sched/topology.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/kernel/sched/topology.c b/kernel/sched/topology.c
> index 10d1391e7416..75b1a18783c2 100644
> --- a/kernel/sched/topology.c
> +++ b/kernel/sched/topology.c
> @@ -767,6 +767,7 @@ cpu_attach_domain(struct sched_domain *sd, struct root_domain *rd, int cpu)
>                          */
>                         do {
>                                 sg->flags = 0;
> +                               sg = sg->next;
>                         } while (sg != sd->groups);

This has been discussed here
https://lore.kernel.org/all/20230523105935.GN83892@hirez.programming.kicks-ass.net/T/#m0881c3e17954dc6e23f81216873e721f8395e554

and here
https://lore.kernel.org/lkml/20230617081926.2035113-1-linmiaohe@huawei.com/

and the right solution would be to remove the while loop but  for
whatever the reason, this has never been resend with an updated commit
message

>
>                         sd->child = NULL;
> --
> 2.39.2
>