linux-kernel - Re: [RFC PATCH v3 0/2] rust: crates in other kernel directories

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK7LNAS+euKhXrU7dxLG40TVvE43e3R-3jyfUH21Y8skZdHjfQ@mail.gmail.com>
Date: Mon, 19 Feb 2024 18:05:43 +0900
From: Masahiro Yamada <masahiroy@...nel.org>
To: Martin Rodriguez Reboredo <yakoyoku@...il.com>
Cc: Miguel Ojeda <ojeda@...nel.org>, Alex Gaynor <alex.gaynor@...il.com>, 
	Wedson Almeida Filho <wedsonaf@...il.com>, Boqun Feng <boqun.feng@...il.com>, Gary Guo <gary@...yguo.net>, 
	Björn Roy Baron <bjorn3_gh@...tonmail.com>, 
	Benno Lossin <benno.lossin@...ton.me>, Andreas Hindborg <a.hindborg@...sung.com>, 
	Alice Ryhl <aliceryhl@...gle.com>, linux-kbuild@...r.kernel.org, 
	linux-kernel@...r.kernel.org, rust-for-linux@...r.kernel.org
Subject: Re: [RFC PATCH v3 0/2] rust: crates in other kernel directories

On Mon, Feb 19, 2024 at 1:11 AM Martin Rodriguez Reboredo
<yakoyoku@...il.com> wrote:
>
> On 11/13/23 11:13, Masahiro Yamada wrote:
> > [...]
> >
> > I will not provide a line-by-line review.
> >
> >
> > Just one thing I'd like to point out.
> >
> > You assume the library (drivers/usb/core/*)
> > is built before its consumers (samples/rust/*).
> >
> > If Kbuild ends up with building lib consumers first,
> > it will be a build error.
> >
> >
> >
> > Kbuild descends into multiple directories in parallel building.
> >
> > You cannot predict which directory is built first.
> >
> > [...]
>
> Thinking with what you've said the same thing might apply to any Rust
> written code that depends on crates under the `rust` dir. Adding
> Make dependencies to object code made from `.rs` will be required if so,
> assuming that Kbuild is intelligent enough to build the crates first.


rust/Makefile specifies dependencies between crates.

I do not know how to specify crate dependencies
across multiple Makefiles, like you did in
drivers/usb/core/Makefile and samples/rust/Makefile.



-- 
Best Regards
Masahiro Yamada