linux-kernel - Re: [PATCH v9 2/2] rtc: max31335: add driver support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Mon, 19 Feb 2024 02:51:57 +0000
From: Chris Packham <Chris.Packham@...iedtelesis.co.nz>
To: Antoniu Miclaus <antoniu.miclaus@...log.com>, Alessandro Zummo
	<a.zummo@...ertech.it>, Alexandre Belloni <alexandre.belloni@...tlin.com>,
	Rob Herring <robh+dt@...nel.org>, Krzysztof Kozlowski
	<krzysztof.kozlowski+dt@...aro.org>, Conor Dooley <conor+dt@...nel.org>,
	"Jean Delvare" <jdelvare@...e.com>, Guenter Roeck <linux@...ck-us.net>,
	"linux-rtc@...r.kernel.org" <linux-rtc@...r.kernel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-hwmon@...r.kernel.org" <linux-hwmon@...r.kernel.org>
Subject: Re: [PATCH v9 2/2] rtc: max31335: add driver support

Hi All,

I'm looking at folding this into the rest of the max313xx support (but 
I'll stick with the max31335 name since that's landed) and I noticed a 
problem.

On 21/11/23 01:00, Antoniu Miclaus wrote:
> RTC driver for MAX31335 ±2ppm Automotive Real-Time Clock with
> Integrated MEMS Resonator.
>
> Reviewed-by: Guenter Roeck <linux@...ck-us.net>
> Signed-off-by: Antoniu Miclaus <antoniu.miclaus@...log.com>
<snip>
> +
> +static bool max31335_volatile_reg(struct device *dev, unsigned int reg)
> +{
> +	/* time keeping registers */
> +	if (reg >= MAX31335_SECONDS &&
> +	    reg < MAX31335_SECONDS + MAX31335_TIME_SIZE)
> +		return true;
> +
> +	/* interrupt status register */
> +	if (reg == MAX31335_INT_EN1_A1IE)
> +		return true;
Presumably this should be something else as MAX31335_INT_EN1_A1IE is a 
bitfield offset not a register.  Based on the other chips I'm guessing 
this should be `reg == MAX31335_STATUS1`. I'll try to incorporate a fix 
into my update but someone might want to fix it up for stable.
> +
> +	/* temperature registers */
> +	if (reg == MAX31335_TEMP_DATA_MSB || MAX31335_TEMP_DATA_LSB)
> +		return true;
> +
> +	return false;
> +}
> +