linux-kernel - Re: [PATCH v18 3/3] vfio/nvgrace-gpu: Add vfio pci variant module for grace hopper

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <SA1PR12MB7199C1C570B00C78311666D2B0512@SA1PR12MB7199.namprd12.prod.outlook.com>
Date: Mon, 19 Feb 2024 09:36:26 +0000
From: Ankit Agrawal <ankita@...dia.com>
To: Zhi Wang <zhi.wang.linux@...il.com>
CC: Jason Gunthorpe <jgg@...dia.com>, "alex.williamson@...hat.com"
	<alex.williamson@...hat.com>, Yishai Hadas <yishaih@...dia.com>,
	"shameerali.kolothum.thodi@...wei.com"
	<shameerali.kolothum.thodi@...wei.com>, "kevin.tian@...el.com"
	<kevin.tian@...el.com>, "mst@...hat.com" <mst@...hat.com>,
	"eric.auger@...hat.com" <eric.auger@...hat.com>, "jgg@...pe.ca"
	<jgg@...pe.ca>, "oleksandr@...alenko.name" <oleksandr@...alenko.name>,
	"clg@...hat.com" <clg@...hat.com>, "satyanarayana.k.v.p@...el.com"
	<satyanarayana.k.v.p@...el.com>, "brett.creeley@....com"
	<brett.creeley@....com>, "horms@...nel.org" <horms@...nel.org>,
	"shannon.nelson@....com" <shannon.nelson@....com>, Aniket Agashe
	<aniketa@...dia.com>, Neo Jia <cjia@...dia.com>, Kirti Wankhede
	<kwankhede@...dia.com>, "Tarun Gupta (SW-GPU)" <targupta@...dia.com>, Vikram
 Sethi <vsethi@...dia.com>, Andy Currid <acurrid@...dia.com>, Alistair Popple
	<apopple@...dia.com>, John Hubbard <jhubbard@...dia.com>, Dan Williams
	<danw@...dia.com>, "Anuj Aggarwal (SW-GPU)" <anuaggarwal@...dia.com>, Matt
 Ochs <mochs@...dia.com>, "kvm@...r.kernel.org" <kvm@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"virtualization@...ts.linux-foundation.org"
	<virtualization@...ts.linux-foundation.org>
Subject: Re: [PATCH v18 3/3] vfio/nvgrace-gpu: Add vfio pci variant module for
 grace hopper

>> diff --git a/drivers/vfio/pci/nvgrace-gpu/main.c
>> b/drivers/vfio/pci/nvgrace-gpu/main.c new file mode 100644
>> index 000000000000..5a251a6a782e
>> --- /dev/null
>> +++ b/drivers/vfio/pci/nvgrace-gpu/main.c
>> @@ -0,0 +1,888 @@
>> +// SPDX-License-Identifier: GPL-2.0-only
>> +/*
>> + * Copyright (c) 2024, NVIDIA CORPORATION & AFFILIATES. All rights
>> reserved
>> + */
>> +
>> +#include <linux/vfio_pci_core.h>
>> +#include <linux/sizes.h>
>> +
>
> Let's keep the header inclusion in an alphabet order.
>
> With that addressed,
>
> Reviewed-by: Zhi Wang <zhi.wang.linux@...il.com>

Yes, will adjust that. Thanks!

>> +/*
>> + * The device memory usable to the workloads running in the VM is
>> cached
>> + * and showcased as a 64b device BAR (comprising of BAR4 and BAR5
>> region)
>> + * to the VM and is represented as usemem.
>> + * Moreover, the VM GPU device driver needs a non-cacheable region to
>> + * support the MIG feature. This region is also exposed as a 64b BAR
>> + * (comprising of BAR2 and BAR3 region) and represented as resmem.
>> + */
>> +#define RESMEM_REGION_INDEX VFIO_PCI_BAR2_REGION_INDEX
>> +#define USEMEM_REGION_INDEX VFIO_PCI_BAR4_REGION_INDEX