linux-kernel - Re: [PATCH v2 2/3] driver core: fw_devlink: Improve detection of overlapping cycles

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMuHMdVon3mdivZQ0O6D4+va0nGBrUQbDp23bEq661QD=4t7+g@mail.gmail.com>
Date: Mon, 19 Feb 2024 11:59:35 +0100
From: Geert Uytterhoeven <geert@...ux-m68k.org>
To: Saravana Kannan <saravanak@...gle.com>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>, "Rafael J. Wysocki" <rafael@...nel.org>, 
	Xu Yang <xu.yang_2@....com>, kernel-team@...roid.com, linux-kernel@...r.kernel.org, 
	Linux-Renesas <linux-renesas-soc@...r.kernel.org>
Subject: Re: [PATCH v2 2/3] driver core: fw_devlink: Improve detection of
 overlapping cycles

Hi Saravana,

On Fri, Feb 2, 2024 at 10:57 AM Saravana Kannan <saravanak@...gle.com> wrote:
> fw_devlink can detect most overlapping/intersecting cycles. However it was
> missing a few corner cases because of an incorrect optimization logic that
> tries to avoid repeating cycle detection for devices that are already
> marked as part of a cycle.

Nice (I assume it's due to this patch ;-), with v6.8-rc5 I see much fewer
dependency cycle messages.

E.g. on Salvator-XS:

-platform fea80000.csi2: Fixed dependency cycle(s) with
/soc/video@...f7000/ports/port@...ndpoint@0
-platform fea80000.csi2: Fixed dependency cycle(s) with
/soc/video@...f6000/ports/port@...ndpoint@0
-platform fea80000.csi2: Fixed dependency cycle(s) with
/soc/video@...f5000/ports/port@...ndpoint@0
-platform fea80000.csi2: Fixed dependency cycle(s) with
/soc/video@...f4000/ports/port@...ndpoint@0
-platform fea80000.csi2: Fixed dependency cycle(s) with
/soc/video@...f3000/ports/port@...ndpoint@0
-platform fea80000.csi2: Fixed dependency cycle(s) with
/soc/video@...f2000/ports/port@...ndpoint@0
-platform fea80000.csi2: Fixed dependency cycle(s) with
/soc/video@...f1000/ports/port@...ndpoint@0
-platform fea80000.csi2: Fixed dependency cycle(s) with
/soc/video@...f0000/ports/port@...ndpoint@0
-platform feaa0000.csi2: Fixed dependency cycle(s) with
/soc/video@...f3000/ports/port@...ndpoint@2
-platform feaa0000.csi2: Fixed dependency cycle(s) with
/soc/video@...f2000/ports/port@...ndpoint@2
-platform feaa0000.csi2: Fixed dependency cycle(s) with
/soc/video@...f1000/ports/port@...ndpoint@2
-platform feaa0000.csi2: Fixed dependency cycle(s) with
/soc/video@...f0000/ports/port@...ndpoint@2
-platform fead0000.hdmi: Fixed dependency cycle(s) with
/soc/sound@...00000/ports/port@...ndpoint
-platform feae0000.hdmi: Fixed dependency cycle(s) with
/soc/sound@...00000/ports/port@...ndpoint
-platform feb00000.display: Fixed dependency cycle(s) with
/soc/hdmi@...e0000/ports/port@...ndpoint
-platform feb00000.display: Fixed dependency cycle(s) with
/soc/hdmi@...d0000/ports/port@...ndpoint
-platform hdmi0-out: Fixed dependency cycle(s) with
/soc/hdmi@...d0000/ports/port@...ndpoint
-platform hdmi1-out: Fixed dependency cycle(s) with
/soc/hdmi@...e0000/ports/port@...ndpoint
-platform vga-encoder: Fixed dependency cycle(s) with /vga/port/endpoint
-platform vga-encoder: Fixed dependency cycle(s) with
/soc/display@...00000/ports/port@...ndpoint

-i2c 2-0010: Fixed dependency cycle(s) with
/soc/sound@...00000/ports/port@...ndpoint
-i2c 2-0010: Fixed dependency cycle(s) with /soc/sound@...00000

-i2c 4-0070: Fixed dependency cycle(s) with
/soc/csi2@...80000/ports/port@...ndpoint
-i2c 4-0070: Fixed dependency cycle(s) with
/soc/csi2@...a0000/ports/port@...ndpoint
-i2c 4-0070: Fixed dependency cycle(s) with /hdmi-in/port/endpoint
-i2c 4-0070: Fixed dependency cycle(s) with /cvbs-in/port/endpoint

FTR, the only remaining ones (on Salvator-XS) are:

    platform soc: Fixed dependency cycle(s) with
/soc/interrupt-controller@...10000
    platform e6060000.pinctrl: Fixed dependency cycle(s) with
/soc/pinctrl@...60000/scif_clk

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68korg

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds