linux-kernel - Re: [PATCH] ACPI: Fix CXL 3.0 structure (RDPAS) in the CEDT table

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Mon, 19 Feb 2024 12:46:35 +0900
From: Hojin Nam <hj96.nam@...sung.com>
To: "Rafael J. Wysocki" <rafael@...nel.org>
Cc: Robert Moore <robert.moore@...el.com>, "Rafael J . Wysocki"
	<rafael.j.wysocki@...el.com>, Len Brown <lenb@...nel.org>,
	linux-acpi@...r.kernel.org, acpica-devel@...ts.linux.dev,
	linux-kernel@...r.kernel.org, ks0204.kim@...sung.com, wj28.lee@...sung.com,
	alison.schofield@...el.com
Subject: Re: [PATCH] ACPI: Fix CXL 3.0 structure (RDPAS) in the CEDT table

On Fri, Feb 16, 2024 at 07:39:15PM +0100, Rafael J. Wysocki wrote:
> On Fri, Feb 16, 2024 at 8:29 AM <hj96.nam@...sung.com> wrote:
> >
> > From: Hojin Nam <hj96.nam@...sung.com>
> >
> > struct acpi_cedt_rdpas does not match with CXL r3.0 9.17.1.5
> > Table 9-24. reserved1 and length fields are already added by
> > struct acpi_cedt_header.
> >
> > Signed-off-by: Hojin Nam <hj96.nam@...sung.com>
> > ---
> >  include/acpi/actbl1.h | 2 --
> 
> This file is part of ACPICA which is a separate project whose code is
> used by the Linux kernel.  In order to make changes in the ACPICA
> code, please submit a pull request to the upstream ACPICA project on
> GitHub.  Once this pull request is merged, you can send a
> corresponding Linux patch with a Link: tag pointing to it.  However,
> it is not necessary to do so, as the changes will be automatically
> included into the ACPICA code in the kernel once a new version of
> ACPICA is out.
>

I submitted PR to the ACPICA project on Github[1].
Thanks for the guide!

Link: https://github.com/acpica/acpica/pull/928 [1]
 
> >  1 file changed, 2 deletions(-)
> >
> > diff --git a/include/acpi/actbl1.h b/include/acpi/actbl1.h
> > index a33375e055ad..7aff8c39dbd6 100644
> > --- a/include/acpi/actbl1.h
> > +++ b/include/acpi/actbl1.h
> > @@ -571,8 +571,6 @@ struct acpi_cedt_cxims {
> >
> >  struct acpi_cedt_rdpas {
> >         struct acpi_cedt_header header;
> > -       u8 reserved1;
> > -       u16 length;
> >         u16 segment;
> >         u16 bdf;
> >         u8 protocol;
> >
> > base-commit: d37e1e4c52bc60578969f391fb81f947c3e83118
> > --
> > 2.34.1
> >
>