linux-kernel - Re: [PATCH v18 2/3] vfio/pci: rename and export range_intersect

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <SA1PR12MB7199A58155EE789213139227B0512@SA1PR12MB7199.namprd12.prod.outlook.com>
Date: Mon, 19 Feb 2024 03:49:29 +0000
From: Ankit Agrawal <ankita@...dia.com>
To: Yishai Hadas <yishaih@...dia.com>, Jason Gunthorpe <jgg@...dia.com>,
	"alex.williamson@...hat.com" <alex.williamson@...hat.com>,
	"shameerali.kolothum.thodi@...wei.com"
	<shameerali.kolothum.thodi@...wei.com>, "kevin.tian@...el.com"
	<kevin.tian@...el.com>, "mst@...hat.com" <mst@...hat.com>,
	"eric.auger@...hat.com" <eric.auger@...hat.com>, "jgg@...pe.ca"
	<jgg@...pe.ca>, "oleksandr@...alenko.name" <oleksandr@...alenko.name>,
	"clg@...hat.com" <clg@...hat.com>, "satyanarayana.k.v.p@...el.com"
	<satyanarayana.k.v.p@...el.com>, "brett.creeley@....com"
	<brett.creeley@....com>, "horms@...nel.org" <horms@...nel.org>,
	"shannon.nelson@....com" <shannon.nelson@....com>
CC: Aniket Agashe <aniketa@...dia.com>, Neo Jia <cjia@...dia.com>, Kirti
 Wankhede <kwankhede@...dia.com>, "Tarun Gupta (SW-GPU)"
	<targupta@...dia.com>, Vikram Sethi <vsethi@...dia.com>, Andy Currid
	<acurrid@...dia.com>, Alistair Popple <apopple@...dia.com>, John Hubbard
	<jhubbard@...dia.com>, Dan Williams <danw@...dia.com>, "Anuj Aggarwal
 (SW-GPU)" <anuaggarwal@...dia.com>, Matt Ochs <mochs@...dia.com>,
	"kvm@...r.kernel.org" <kvm@...r.kernel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "virtualization@...ts.linux-foundation.org"
	<virtualization@...ts.linux-foundation.org>
Subject: Re: [PATCH v18 2/3] vfio/pci: rename and export range_intersect_range

>> +
>> +/**
>> + * vfio_pci_core_range_intersect_range() - Determine overlap between a buffer
>> + *                                      and register offset ranges.
>> + * @buf_start:               start offset of the buffer
>> + * @buf_cnt:         number of buffer bytes.
>
> You could drop the '.' at the end to be consistent with the other.

Ok, will make it consistent.

>> +bool vfio_pci_core_range_intersect_range(loff_t buf_start, size_t buf_cnt,
>> +                                      loff_t reg_start, size_t reg_cnt,
>> +                                      loff_t *buf_offset,
>> +                                      size_t *intersect_count,
>> +                                      size_t *register_offset);
>>   #define VFIO_IOWRITE_DECLATION(size) \
>>   int vfio_pci_core_iowrite##size(struct vfio_pci_core_device *vdev,  \
>>                        bool test_mem, u##size val, void __iomem *io);
>
> Reviewed-by: Yishai Hadas <yishaih@...dia.com>

Thanks