linux-kernel - Re: [PATCH] [v2] scsi: mpi3mr: reduce stack usage in mpi3mr_refresh_sas

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <96bb914c-79be-4867-b59d-62f80dbcdace@oracle.com>
Date: Mon, 19 Feb 2024 12:08:24 +0000
From: John Garry <john.g.garry@...cle.com>
To: Arnd Bergmann <arnd@...nel.org>,
        Sathya Prakash Veerichetty <sathya.prakash@...adcom.com>,
        Kashyap Desai <kashyap.desai@...adcom.com>,
        Sumit Saxena <sumit.saxena@...adcom.com>,
        Sreekanth Reddy <sreekanth.reddy@...adcom.com>
Cc: Arnd Bergmann <arnd@...db.de>,
        Johannes Thumshirn <johannes.thumshirn@....com>,
        "James E.J. Bottomley" <jejb@...ux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>,
        Ranjan Kumar <ranjan.kumar@...adcom.com>,
        Tomas Henzl <thenzl@...hat.com>,
        Harshit Mogalapalli <harshit.m.mogalapalli@...cle.com>,
        mpi3mr-linuxdrv.pdl@...adcom.com, linux-scsi@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] [v2] scsi: mpi3mr: reduce stack usage in
 mpi3mr_refresh_sas_ports()

On 23/01/2024 13:07, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@...db.de>
> 
> Doubling the number of PHYs also doubled the stack usage of this function,
> exceeding the 32-bit limit of 1024 bytes:
> 
> drivers/scsi/mpi3mr/mpi3mr_transport.c: In function 'mpi3mr_refresh_sas_ports':
> drivers/scsi/mpi3mr/mpi3mr_transport.c:1818:1: error: the frame size of 1636 bytes is larger than 1024 bytes [-Werror=frame-larger-than=]
> 
> Since the sas_io_unit_pg0 structure is already allocated dynamically, use
> the same method here. The size of the allocation can be smaller based on the
> actual number of phys now, so use this as an upper bound.
> 
> Fixes: cb5b60894602 ("scsi: mpi3mr: Increase maximum number of PHYs to 64 from 32")
> Reviewed-by: Johannes Thumshirn <johannes.thumshirn@....com>
> Cc: Sathya Prakash Veerichetty <sathya.prakash@...adcom.com>
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Has this patch been missed?

I have this same build issue for i386 allmodconfig on v6.8-rc5 and earlier

Tested-by: John Garry <john.g.garry@...cle.com> #build only