linux-kernel - Re: [PATCH v3] PCI: Increase maximum PCIe physical function number to 7 for non-ARI devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <fe5d0d5c3cdebc8d637c348f3759330166604bb0.camel@iokpp.de>
Date: Mon, 19 Feb 2024 13:09:14 +0100
From: Bean Huo <beanhuo@...pp.de>
To: Siddharth Vadapalli <s-vadapalli@...com>
Cc: bhelgaas@...gle.com, helgaas@...nel.org, 
	sathyanarayanan.kuppuswamy@...ux.intel.com, linux-pci@...r.kernel.org, 
	linux-kernel@...r.kernel.org, Bean Huo <beanhuo@...ron.com>, 
	stable@...r.kernel.org
Subject: Re: [PATCH v3] PCI: Increase maximum PCIe physical function number
 to 7 for non-ARI devices

On Mon, 2024-02-19 at 17:30 +0530, Siddharth Vadapalli wrote:
> The function "next_fn()" seems to provide the next valid function.
> Therefore, if the current function is 0 (fn = 0), then the next valid
> function will be 1 which is returned by next_fn(). It extends
> similarly
> until the case where current function is 6 (fn = 6) which shall
> return
> the next valid function as 7. So all 8 PFs are still treated as valid
> and there doesn't seem to be any limitation. Only in the case where
> the
> EP doesn't support ARI (there is no function 8 (fn = 8)), the call to
> next_fn() with the fn parameter set to 7, will return -ENODEV which
> seems to be the expected behavior.
> 
> Regards,
> Siddharth.

yes, you are right, the fn 7 has no next_fn, hence should return -
ENODEV. 

ignore this patch!

kind regards,
Bean