linux-kernel - Re: [net-next RFC PATCH 6/6] net: phy: bcm7xxx: rework phy_driver table to new multiple PHY ID format

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6146eb3b-720a-4523-bcc7-8e2656aeafef@gmail.com>
Date: Sun, 18 Feb 2024 20:26:29 -0800
From: Florian Fainelli <f.fainelli@...il.com>
To: Christian Marangi <ansuelsmth@...il.com>, Andrew Lunn <andrew@...n.ch>,
 Heiner Kallweit <hkallweit1@...il.com>, Russell King
 <linux@...linux.org.uk>, "David S. Miller" <davem@...emloft.net>,
 Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
 Paolo Abeni <pabeni@...hat.com>,
 Florian Fainelli <florian.fainelli@...adcom.com>,
 Broadcom internal kernel review list
 <bcm-kernel-feedback-list@...adcom.com>, Robert Marko <robimarko@...il.com>,
 "Russell King (Oracle)" <rmk+kernel@...linux.org.uk>,
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
 Pieter Jansen van Vuuren <pieter.jansen-van-vuuren@....com>,
 Nipun Gupta <nipun.gupta@....com>,
 Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
 Puneet Gupta <puneet.gupta@....com>,
 Abhijit Gangurde <abhijit.gangurde@....com>,
 Umang Jain <umang.jain@...asonboard.com>, netdev@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [net-next RFC PATCH 6/6] net: phy: bcm7xxx: rework phy_driver
 table to new multiple PHY ID format

On 2/18/2024 11:00 AM, Christian Marangi wrote:
> Rework bcm7xxx PHY driver table to new multiple PHY format
> implementation to reduce code duplication and final size of the compiled
> module.

I like the idea of sharing as much code as possible and creating a 
smaller module, however by changing the name, you are creating an 
user-space ABI change, we rely upon the exact PHY name being shown under 
/sys/class/mdio_bus/*/* and this change will break that.

Thanks!
-- 
Florian