linux-kernel - Re: [PATCH] mm: memcontrol: clarify swapaccount=0 deprecation warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ch7mbvyfcvc5yswykpgj5i73okgt4dnovelqhpuv22puw7gpba@6vj6d2z2yhau>
Date: Mon, 19 Feb 2024 15:29:11 +0100
From: Michal Koutný <mkoutny@...e.com>
To: Johannes Weiner <hannes@...xchg.org>
Cc: Andrew Morton <akpm@...ux-foundation.org>, 
	Michal Hocko <mhocko@...nel.org>, Shakeel Butt <shakeelb@...gle.com>, 
	Roman Gushchin <roman.gushchin@...ux.dev>, linux-mm@...ck.org, cgroups@...r.kernel.org, 
	linux-kernel@...r.kernel.org, Jonas Schäfer <jonas@...licki.name>, 
	Narcis Garcia <debianlists@...iu.net>, Yosry Ahmed <yosryahmed@...gle.com>
Subject: Re: [PATCH] mm: memcontrol: clarify swapaccount=0 deprecation warning

On Tue, Feb 13, 2024 at 03:16:34AM -0500, Johannes Weiner <hannes@...xchg.org> wrote:
> The swapaccount deprecation warning is throwing false positives. Since
> we deprecated the knob and defaulted to enabling, the only reports
> we've been getting are from folks that set swapaccount=1. While this
> is a nice affirmation that always-enabling was the right choice, we
> certainly don't want to warn when users request the supported mode.

But shouldn't such users be still warned about effectively unused option?
I think `return 0;` from the param handler should ensure that.


> +	if (!kstrtobool(s, &res) && !res)
> +		pr_warn_once("The swapaccount=0 commdandline option is deprecated "
                                                commandline

Regards,
Michal

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)