[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ddd5157cc9e61c218edff5cae572119d67b2717d.camel@linux.ibm.com>
Date: Mon, 19 Feb 2024 16:33:33 +0100
From: Ilya Leoshkevich <iii@...ux.ibm.com>
To: Christophe Leroy <christophe.leroy@...roup.eu>,
Alexei Starovoitov
<ast@...nel.org>,
Daniel Borkmann <daniel@...earbox.net>,
Andrii Nakryiko
<andrii@...nel.org>,
Martin KaFai Lau <martin.lau@...ux.dev>,
Eduard
Zingerman <eddyz87@...il.com>, Song Liu <song@...nel.org>,
Yonghong Song
<yonghong.song@...ux.dev>,
John Fastabend <john.fastabend@...il.com>,
KP
Singh <kpsingh@...nel.org>, Stanislav Fomichev <sdf@...gle.com>,
Hao Luo
<haoluo@...gle.com>, Jiri Olsa <jolsa@...nel.org>,
Russell King
<linux@...linux.org.uk>,
Puranjay Mohan <puranjay12@...il.com>,
Zi Shen Lim
<zlim.lnx@...il.com>,
Catalin Marinas <catalin.marinas@....com>,
Will
Deacon <will@...nel.org>, Tiezhu Yang <yangtiezhu@...ngson.cn>,
Hengqi Chen
<hengqi.chen@...il.com>,
Huacai Chen <chenhuacai@...nel.org>, WANG Xuerui
<kernel@...0n.name>,
Johan Almbladh <johan.almbladh@...finetworks.com>,
Paul Burton <paulburton@...nel.org>,
Thomas Bogendoerfer
<tsbogend@...ha.franken.de>,
"James E.J. Bottomley"
<James.Bottomley@...senPartnership.com>,
Helge Deller <deller@....de>, Heiko Carstens <hca@...ux.ibm.com>,
Vasily Gorbik <gor@...ux.ibm.com>,
Alexander Gordeev <agordeev@...ux.ibm.com>,
Christian Borntraeger
<borntraeger@...ux.ibm.com>,
Sven Schnelle <svens@...ux.ibm.com>,
"David
S. Miller" <davem@...emloft.net>,
Andreas Larsson <andreas@...sler.com>,
Wang YanQing <udknight@...il.com>, David Ahern <dsahern@...nel.org>,
Thomas
Gleixner <tglx@...utronix.de>, Ingo Molnar <mingo@...hat.com>,
Borislav
Petkov <bp@...en8.de>,
Dave Hansen <dave.hansen@...ux.intel.com>, x86@...nel.org,
"H. Peter Anvin" <hpa@...or.com>
Cc: bpf@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
linux-kernel@...r.kernel.org, loongarch@...ts.linux.dev,
linux-mips@...r.kernel.org, linux-parisc@...r.kernel.org,
linux-s390@...r.kernel.org, sparclinux@...r.kernel.org,
netdev@...r.kernel.org, Kees Cook <keescook@...omium.org>,
"linux-hardening @ vger . kernel . org" <linux-hardening@...r.kernel.org>
Subject: Re: [PATCH bpf-next 2/2] bpf: Take return from set_memory_rox()
into account with bpf_jit_binary_lock_ro()
On Sun, 2024-02-18 at 11:55 +0100, Christophe Leroy wrote:
> set_memory_rox() can fail, leaving memory unprotected.
>
> Check return and bail out when bpf_jit_binary_lock_ro() returns
> and error.
>
> Signed-off-by: Christophe Leroy <christophe.leroy@...roup.eu>
> ---
> Previous patch introduces a dependency on this patch because it
> modifies bpf_prog_lock_ro(), but they are independant.
> It is possible to apply this patch as standalone by handling trivial
> conflict with unmodified bpf_prog_lock_ro().
> ---
> arch/arm/net/bpf_jit_32.c | 25 ++++++++++++-------------
> arch/arm64/net/bpf_jit_comp.c | 21 +++++++++++++++------
> arch/loongarch/net/bpf_jit.c | 21 +++++++++++++++------
> arch/mips/net/bpf_jit_comp.c | 3 ++-
> arch/parisc/net/bpf_jit_core.c | 8 +++++++-
> arch/s390/net/bpf_jit_comp.c | 6 +++++-
> arch/sparc/net/bpf_jit_comp_64.c | 6 +++++-
> arch/x86/net/bpf_jit_comp32.c | 3 +--
> include/linux/filter.h | 4 ++--
> 9 files changed, 64 insertions(+), 33 deletions(-)
Reviewed-by: Ilya Leoshkevich <iii@...ux.ibm.com> # s390x
Powered by blists - more mailing lists