linux-kernel - Re: [PATCH v13 2/3] iio: adc: ad_sigma

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <001d1e99-5d96-44f3-8695-ad2ecee42128@gmail.com>
Date: Tue, 20 Feb 2024 16:13:12 +0200
From: Ceclan Dumitru <mitrutzceclan@...il.com>
To: Andy Shevchenko <andy@...nel.org>
Cc: linus.walleij@...aro.org, brgl@...ev.pl, linux-gpio@...r.kernel.org,
 Lars-Peter Clausen <lars@...afoo.de>, Jonathan Cameron <jic23@...nel.org>,
 Rob Herring <robh+dt@...nel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
 Conor Dooley <conor+dt@...nel.org>, Michael Walle <michael@...le.cc>,
 Arnd Bergmann <arnd@...db.de>, ChiaEn Wu <chiaen_wu@...htek.com>,
 Niklas Schnelle <schnelle@...ux.ibm.com>,
 Leonard Göhrs <l.goehrs@...gutronix.de>,
 Mike Looijmans <mike.looijmans@...ic.nl>, Haibo Chen <haibo.chen@....com>,
 Hugo Villeneuve <hvilleneuve@...onoff.com>,
 David Lechner <dlechner@...libre.com>,
 Ceclan Dumitru <dumitru.ceclan@...log.com>, linux-iio@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v13 2/3] iio: adc: ad_sigma_delta: Add optional irq
 selection



On 2/20/24 16:11, Andy Shevchenko wrote:
> On Tue, Feb 20, 2024 at 11:43:39AM +0200, Dumitru Ceclan wrote:
>> Add optional irq_num attribute to ad_sigma_delta_info structure for
>> selecting the used interrupt line for adc's conversion completion.
> 
> ...
> 
>> +	if (!info->irq_num)
>> +		sigma_delta->irq_num = spi->irq;
>> +	else
>> +		sigma_delta->irq_num = info->irq_num;
> 
> Why not positive check?
> 
Considered that selecting spi->irq is usually the default case, so it
should be the first branch