linux-kernel - Re: [PATCH v5 2/2] media: i2c: Add GC08A3 image sensor driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 20 Feb 2024 17:19:14 +0200
From: Andy Shevchenko <andy.shevchenko@...il.com>
To: Zhi Mao <zhi.mao@...iatek.com>
Cc: mchehab@...nel.org, robh+dt@...nel.org, krzysztof.kozlowski+dt@...aro.org, 
	sakari.ailus@...ux.intel.com, laurent.pinchart@...asonboard.com, 
	shengnan.wang@...iatek.com, yaya.chang@...iatek.com, 10572168@...com, 
	Project_Global_Chrome_Upstream_Group@...iatek.com, yunkec@...omium.org, 
	conor+dt@...nel.org, matthias.bgg@...il.com, 
	angelogioacchino.delregno@...labora.com, jacopo.mondi@...asonboard.com, 
	hverkuil-cisco@...all.nl, heiko@...ech.de, jernej.skrabec@...il.com, 
	macromorgan@...mail.com, linus.walleij@...aro.org, hdegoede@...hat.com, 
	tomi.valkeinen@...asonboard.com, gerald.loacker@...fvision.net, 
	bingbu.cao@...el.com, dan.scally@...asonboard.com, 
	linux-media@...r.kernel.org, devicetree@...r.kernel.org, 
	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, 
	linux-mediatek@...ts.infradead.org
Subject: Re: [PATCH v5 2/2] media: i2c: Add GC08A3 image sensor driver

On Tue, Feb 20, 2024 at 3:47 AM Zhi Mao <zhi.mao@...iatek.com> wrote:
>
> Add a V4L2 sub-device driver for Galaxycore GC08A3 image sensor.

..

> +#include <asm/unaligned.h>

Usually asm/* go after linux/*

> +#include <linux/clk.h>
> +#include <linux/delay.h>
> +#include <linux/gpio/consumer.h>
> +#include <linux/i2c.h>
> +#include <linux/module.h>
> +#include <linux/pm_runtime.h>
> +#include <linux/regulator/consumer.h>

This looks semi-random.
For example, _at least_ the array_size.h, bits.h, container_of.h,
device.h, err.h, mod_devicetable.h, property.h, types.h are missing,
Please, use IWYU principle.

..

> +#define GC08A3_DEFAULT_CLK_FREQ 24000000

HZ_PER_MHZ ?

..

> +#define GC08A3_SLEEP_US  2000

USEC_PER_MSEC ?

..

> +static const s64 gc08a3_link_freq_menu_items[] = {
> +       336000000ULL,
> +       207000000ULL,

HZ_PER_MHZ ?

> +};

..

> +static const struct dev_pm_ops gc08a3_pm_ops = {
> +       SET_RUNTIME_PM_OPS(gc08a3_power_off, gc08a3_power_on, NULL)
> +};

> +               .pm = &gc08a3_pm_ops,

Use new PM macros (pm_ptr() and friends).

-- 
With Best Regards,
Andy Shevchenko