linux-kernel - Re: [PATCH v1] HID: nintendo: Don't fail on setting baud rate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <dd1c1536-f36b-4615-97b7-7f6ea4b5e5a9@enpas.org>
Date: Wed, 21 Feb 2024 02:20:02 +0900
From: Max Staudt <max@...as.org>
To: "Daniel J . Ogorchock" <djogorchock@...il.com>,
 Jiri Kosina <jikos@...nel.org>,
 Benjamin Tissoires <benjamin.tissoires@...hat.com>
Cc: linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1] HID: nintendo: Don't fail on setting baud rate

Ping :)

Do you think this patch could be upstreamed to widen the controller support?

Thank you for looking at this!

Max

On 1/15/24 23:50, Max Staudt wrote:
> Some third-party controllers can't change the baud rate.
> 
> We can still use the gamepad as-is, so let's do that.
> 
> Signed-off-by: Max Staudt <max@...as.org>
> ---
>   drivers/hid/hid-nintendo.c | 5 ++++-
>   1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/hid/hid-nintendo.c b/drivers/hid/hid-nintendo.c
> index 997c3a1adaca..8cba0612c3ae 100644
> --- a/drivers/hid/hid-nintendo.c
> +++ b/drivers/hid/hid-nintendo.c
> @@ -2164,8 +2164,11 @@ static int joycon_init(struct hid_device *hdev)
>   		/* set baudrate for improved latency */
>   		ret = joycon_send_usb(ctlr, JC_USB_CMD_BAUDRATE_3M, HZ);
>   		if (ret) {
> +			/*
> +			 * We can function with the default baudrate.
> +			 * Provide a warning, and continue on.
> +			 */
>   			hid_err(hdev, "Failed to set baudrate; ret=%d\n", ret);
> -			goto out_unlock;
>   		}
>   		/* handshake */
>   		ret = joycon_send_usb(ctlr, JC_USB_CMD_HANDSHAKE, HZ);