linux-kernel - Re: [PATCH] LoongArch: Call early_init_fdt_scan_reserved

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e59f02e4-03c9-42dc-9c04-65d339fa8cc2@quicinc.com>
Date: Tue, 20 Feb 2024 09:37:15 -0800
From: Oreoluwa Babatunde <quic_obabatun@...cinc.com>
To: Huacai Chen <chenhuacai@...ngson.cn>, Huacai Chen <chenhuacai@...nel.org>
CC: <loongarch@...ts.linux.dev>, Xuefeng Li <lixuefeng@...ngson.cn>,
        Guo Ren
	<guoren@...nel.org>, Xuerui Wang <kernel@...0n.name>,
        Jiaxun Yang
	<jiaxun.yang@...goat.com>, <linux-kernel@...r.kernel.org>,
        <loongson-kernel@...ts.loongnix.cn>, <kernel@...cinc.com>
Subject: Re: [PATCH] LoongArch: Call early_init_fdt_scan_reserved_mem()
 earlier


On 2/18/2024 7:14 AM, Huacai Chen wrote:
> The unflatten_and_copy_device_tree() function contains a call to
> memblock_alloc(). This means that memblock is allocating memory before
> any of the reserved memory regions are set aside in the arch_mem_init()
> function which calls early_init_fdt_scan_reserved_mem(). Therefore,
> there is a possibility for memblock to allocate from any of the
> reserved memory regions.
>
> Hence, move the call to early_init_fdt_scan_reserved_mem() to be earlier
> in the init sequence, so that the reserved memory regions are set aside
> before any allocations are done using memblock.
>
> Signed-off-by: Oreoluwa Babatunde <quic_obabatun@...cinc.com>
> Signed-off-by: Huacai Chen <chenhuacai@...ngson.cn>
> ---
>  arch/loongarch/kernel/setup.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/loongarch/kernel/setup.c b/arch/loongarch/kernel/setup.c
> index edf2bba80130..634ef17fd38b 100644
> --- a/arch/loongarch/kernel/setup.c
> +++ b/arch/loongarch/kernel/setup.c
> @@ -357,6 +357,8 @@ void __init platform_init(void)
>  	acpi_gbl_use_default_register_widths = false;
>  	acpi_boot_table_init();
>  #endif
> +
> +	early_init_fdt_scan_reserved_mem();
>  	unflatten_and_copy_device_tree();
>  
>  #ifdef CONFIG_NUMA
> @@ -390,8 +392,6 @@ static void __init arch_mem_init(char **cmdline_p)
>  
>  	check_kernel_sections_mem();
>  
> -	early_init_fdt_scan_reserved_mem();
> -
>  	/*
>  	 * In order to reduce the possibility of kernel panic when failed to
>  	 * get IO TLB memory under CONFIG_SWIOTLB, it is better to allocate
Hi Huacai,

Thank you! This change looks good to me.

Regards,

Oreoluwa