linux-kernel - Re: [PATCH v3 1/1] tcp/dcpp: Un-pin tw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <xhsmhmsrvf33i.mognet@vschneid-thinkpadt14sgen2i.remote.csb>
Date: Tue, 20 Feb 2024 18:38:25 +0100
From: Valentin Schneider <vschneid@...hat.com>
To: Kuniyuki Iwashima <kuniyu@...zon.com>
Cc: bigeasy@...utronix.de, davem@...emloft.net, dccp@...r.kernel.org,
 dsahern@...nel.org, edumazet@...gle.com, juri.lelli@...hat.com,
 kuba@...nel.org, linux-kernel@...r.kernel.org,
 linux-rt-users@...r.kernel.org, mleitner@...hat.com,
 netdev@...r.kernel.org, pabeni@...hat.com, tglozar@...hat.com,
 tglx@...utronix.de, kuniyu@...zon.com
Subject: Re: [PATCH v3 1/1] tcp/dcpp: Un-pin tw_timer

On 19/02/24 10:55, Kuniyuki Iwashima wrote:
> From: Valentin Schneider <vschneid@...hat.com>
>> @@ -53,16 +53,14 @@ void dccp_time_wait(struct sock *sk, int state, int timeo)
>>  		if (state == DCCP_TIME_WAIT)
>>  			timeo = DCCP_TIMEWAIT_LEN;
>>  
>> -		/* tw_timer is pinned, so we need to make sure BH are disabled
>> -		 * in following section, otherwise timer handler could run before
>> -		 * we complete the initialization.
>> -		 */
>> -		local_bh_disable();
>> -		inet_twsk_schedule(tw, timeo);
>> -		/* Linkage updates.
>> -		 * Note that access to tw after this point is illegal.
>> -		 */
>> +	       local_bh_disable();
>
> This line seems not correctly indented, same for TCP change.
>
>
>
>> +
>> +		// Linkage updates
>>  		inet_twsk_hashdance(tw, sk, &dccp_hashinfo);
>> +		inet_twsk_schedule(tw, timeo);
>> +		// Access to tw after this point is illegal.
>
> Also please use /**/ style for these comments, same for TCP too.
>

Will do, thanks!