linux-kernel - Re: [PATCH] test_xarray: fix soft lockup for advanced-api tests

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20240220110050.210b1f2866d2c80716d021e8@linux-foundation.org>
Date: Tue, 20 Feb 2024 11:00:50 -0800
From: Andrew Morton <akpm@...ux-foundation.org>
To: Luis Chamberlain <mcgrof@...nel.org>
Cc: willy@...radead.org, linux-fsdevel@...r.kernel.org, linux-mm@...ck.org,
 linux-kernel@...r.kernel.org, gost.dev@...sung.com, p.raghav@...sung.com,
 da.gomez@...sung.com, kernel test robot <oliver.sang@...el.com>
Subject: Re: [PATCH] test_xarray: fix soft lockup for advanced-api tests

On Tue, 20 Feb 2024 09:45:19 -0800 Luis Chamberlain <mcgrof@...nel.org> wrote:

> > > --- a/lib/test_xarray.c
> > > +++ b/lib/test_xarray.c
> > > @@ -781,6 +781,7 @@ static noinline void *test_get_entry(struct xarray *xa, unsigned long index)
> > >  {
> > >  	XA_STATE(xas, xa, index);
> > >  	void *p;
> > > +	static unsigned int i = 0;
> > 
> > I don't think this needs static storage.
> 
> Actually it does, without it the schedule never happens and produces the
> soft lockup in the splat below.:

OK, I'll restore that.