linux-kernel - Re: Linux 6.8-rc5

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 20 Feb 2024 13:48:07 -0800
From: Guenter Roeck <linux@...ck-us.net>
To: Linus Torvalds <torvalds@...ux-foundation.org>,
 Matthew Auld <matthew.auld@...el.com>,
 Arunpravin Paneer Selvam <Arunpravin.PaneerSelvam@....com>,
 Christian König <christian.koenig@....com>
Cc: Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: Linux 6.8-rc5

Actually,

On 2/20/24 11:57, Linus Torvalds wrote:

>> Commit a64056bb5a32 ("drm/tests/drm_buddy: add alloc_contiguous test"):
>>
>> +       u64 mm_size, ps = SZ_4K, i, n_pages, total;
>> ...
>> +       n_pages = mm_size / ps;
> 

Turns out it wasn't this code, but

> Now, the __moddi3() is a *bit* more reasonable, because I assume it comes from
> 
>                  int slot = i % 3;
> 

this code. Sorry, I guess I should have spent more time on it.
Just declaring i as int solves the problem. In my case I used
gcc 11.4. I since also tried with gcc 13.1, but that makes
the problem worse. With that, I get

          U __moddi3
          U __umoddi3
          U __umulsidi3

No idea why a single assignment would result in three undefined
symbols, but there we are. This is with xtensa, but I assume
the same is true for other architectures.

Unfortunately, I can not test your attached patch because the
DRM unit tests blow up my qemu test machines.

Guenter