linux-kernel - Re: [PATCH] jfs: fix uaf in jfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZdQlbc0Hb0UZy6od@casper.infradead.org>
Date: Tue, 20 Feb 2024 04:07:09 +0000
From: Matthew Wilcox <willy@...radead.org>
To: Edward Adam Davis <eadavis@...com>
Cc: syzbot+c244f4a09ca85dd2ebc1@...kaller.appspotmail.com,
	jfs-discussion@...ts.sourceforge.net, linux-fsdevel@...r.kernel.org,
	linux-kernel@...r.kernel.org, shaggy@...nel.org,
	syzkaller-bugs@...glegroups.com
Subject: Re: [PATCH] jfs: fix uaf in jfs_syncpt

On Tue, Feb 20, 2024 at 11:55:18AM +0800, Edward Adam Davis wrote:
> During the execution of the jfs lazy commit, the jfs file system was unmounted,
> causing the sbi and jfs log objects to be released, triggering this issue.
> The solution is to add mutex to synchronize jfs lazy commit and jfs unmount 
> operations.

Why is that the solution?  LAZY_LOCK with IN_LAZYCOMMIT is supposed to
cover this.  Please be more verbose in your commit messages.  Describe
what is going wrong and why; that will allow people to understand why
this is the correct solution to the problem.