linux-kernel - Re: [PATCH] drivers/tty/serial: Remove unused function early_mcf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c44bfc7f-7b06-4985-953d-185f8b576a5b@kernel.org>
Date: Tue, 20 Feb 2024 06:11:47 +0100
From: Jiri Slaby <jirislaby@...nel.org>
To: Thomas Huth <thuth@...hat.com>, linux-m68k@...ts.linux-m68k.org,
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
 Greg Ungerer <gerg@...ux-m68k.org>, Geert Uytterhoeven <geert@...ux-m68k.org>
Cc: linux-kernel@...r.kernel.org, linux-serial@...r.kernel.org
Subject: Re: [PATCH] drivers/tty/serial: Remove unused function
 early_mcf_setup

On 19. 02. 24, 17:40, Thomas Huth wrote:
> Compiling a kernel for the ColdFire causes a compiler warning:
> 
> drivers/tty/serial/mcf.c:473:12: warning: no previous prototype for
>   ‘early_mcf_setup’ [-Wmissing-prototypes]
>    473 | int __init early_mcf_setup(struct mcf_platform_uart *platp)
>        |            ^~~~~~~~~~~~~~~
> 
> This function seems to be completely unused, so let's remove it
> to silence the warning.

And it seems so since the driver addition in 2007 by:
commit 49aa49bfd40d718095669c1c70c9d167b814e29b
Author: Greg Ungerer <gerg@...pgear.com>
Date:   Tue Oct 23 14:37:54 2007 +1000

     m68knommu: new style ColdFire UART driver



Reviewed-by: Jiri Slaby <jirislaby@...nel.org>

thanks,
-- 
js
suse labs