linux-kernel - Re: [PATCH] ASoC: SOF: amd: fix soundwire dependencies

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <412c0a42-4c19-48dd-aa4e-de39b6ec3099@app.fastmail.com>
Date: Tue, 20 Feb 2024 07:13:39 +0100
From: "Arnd Bergmann" <arnd@...db.de>
To: "Vijendar Mukunda" <vijendar.mukunda@....com>,
 "Arnd Bergmann" <arnd@...nel.org>,
 "Pierre-Louis Bossart" <pierre-louis.bossart@...ux.intel.com>,
 "Liam Girdwood" <lgirdwood@...il.com>,
 "Peter Ujfalusi" <peter.ujfalusi@...ux.intel.com>,
 "Bard Liao" <yung-chuan.liao@...ux.intel.com>,
 "Ranjani Sridharan" <ranjani.sridharan@...ux.intel.com>,
 "Daniel Baluta" <daniel.baluta@....com>, "Mark Brown" <broonie@...nel.org>
Cc: "Kai Vehmanen" <kai.vehmanen@...ux.intel.com>,
 "Jaroslav Kysela" <perex@...ex.cz>, "Takashi Iwai" <tiwai@...e.com>,
 "V sujith kumar Reddy" <Vsujithkumar.Reddy@....com>,
 "Venkata Prasad Potturu" <venkataprasad.potturu@....com>,
 sound-open-firmware@...a-project.org, linux-sound@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ASoC: SOF: amd: fix soundwire dependencies

On Tue, Feb 20, 2024, at 06:57, Mukunda,Vijendar wrote:
> On 19/02/24 15:08, Arnd Bergmann wrote:
>> From: Arnd Bergmann <arnd@...db.de>

>> In normal configs, they should all either be built-in or all loadable
>> modules anyway, so this simplification does not limit any real usecases.
>
> Tested this patch. SOUNWIRE_AMD flag is not selected by default causing
> AMD SOF driver for ACP 6.3 platform is build without enabling SoundWire.

Yes, that is what I described. But as SOUNWIRE_AMD is a user visible
symbol, there is no problem in expecting users to enable it when they
have this hardware, and distros just enable all the drivers anyway.

    Arnd