[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <2024022024-trout-kennel-6d14@gregkh>
Date: Tue, 20 Feb 2024 09:34:28 +0100
From: Greg KH <gregkh@...uxfoundation.org>
To: Ray Chi <raychi@...gle.com>
Cc: Thinh.Nguyen@...opsys.com, quic_uaggarwa@...cinc.com,
albertccwang@...gle.com, linux-usb@...r.kernel.org,
linux-kernel@...r.kernel.org, stable@...r.kernel.org
Subject: Re: [PATCH] usb: dwc3: gadget: remove warning during kernel boot
On Tue, Feb 20, 2024 at 04:12:04PM +0800, Ray Chi wrote:
> The dwc3->gadget_driver is not initialized during the dwc3 probe
> process. This leads to a warning when the runtime power management (PM)
> attempts to suspend the gadget using dwc3_gadget_suspend().
What type of warning happens?
> This patch adds a check to prevent the warning.
>
> Cc: stable@...r.kernel.org
> Fixes: 61a348857e86 ("usb: dwc3: gadget: Fix NULL pointer dereference in dwc3_gadget_suspend")
> Signed-off-by: Ray Chi <raychi@...gle.com>
> ---
> drivers/usb/dwc3/gadget.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c
> index 28f49400f3e8..de987cffe1ec 100644
> --- a/drivers/usb/dwc3/gadget.c
> +++ b/drivers/usb/dwc3/gadget.c
> @@ -4708,6 +4708,9 @@ int dwc3_gadget_suspend(struct dwc3 *dwc)
> unsigned long flags;
> int ret;
>
> + if (!dwc->gadget_driver)
> + return 0;
> +
This directly reverts part of the commit you say this fixes, are you
SURE about this? Why?
thanks,
greg k-h
Powered by blists - more mailing lists