linux-kernel - Re: [PATCH] sparc: Fix undefined reference to fb_is_primary

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <476ca8e4-b0c8-4be2-ad65-8430c7f4acc9@app.fastmail.com>
Date: Tue, 20 Feb 2024 09:40:50 +0100
From: "Arnd Bergmann" <arnd@...db.de>
To: "Javier Martinez Canillas" <javierm@...hat.com>,
 linux-kernel@...r.kernel.org
Cc: "kernel test robot" <lkp@...el.com>, oe-kbuild-all@...ts.linux.dev,
 "Andreas Larsson" <andreas@...sler.com>,
 "David S . Miller" <davem@...emloft.net>, "Helge Deller" <deller@....de>,
 "Thomas Zimmermann" <tzimmermann@...e.de>, sparclinux@...r.kernel.org
Subject: Re: [PATCH] sparc: Fix undefined reference to fb_is_primary_device

On Tue, Feb 20, 2024, at 01:34, Javier Martinez Canillas wrote:
> Commit 55bffc8170bb ("fbdev: Split frame buffer support in FB and FB_CORE
> symbols") added a new FB_CORE Kconfig symbol, that can be enabled to only
> have fbcon/VT and DRM fbdev emulation, but without support for any legacy
> fbdev driver.
>
> Unfortunately, it missed to change a CONFIG_FB in arch/sparc/Makefile and
> that leads to the following linking error in some sparc64 configurations:
>
>    sparc64-linux-ld: drivers/video/fbdev/core/fbcon.o: in function 
> `fbcon_fb_registered':
>>> fbcon.c:(.text+0x4f60): undefined reference to `fb_is_primary_device'
>
> Fixes: 55bffc8170bb ("fbdev: Split frame buffer support in FB and 
> FB_CORE symbols")
> Reported-by: kernel test robot <lkp@...el.com>
> Closes: https://lore.kernel.org/r/202401290306.IV8rhJ02-lkp@intel.com/
> Signed-off-by: Javier Martinez Canillas <javierm@...hat.com>

Acked-by; Arnd Bergmann <arnd@...db.de>