linux-kernel - Re: [PATCH v6 0/4] Enable >0 order folio memory compaction

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Mon, 19 Feb 2024 18:06:17 -0800
From: Andrew Morton <akpm@...ux-foundation.org>
To: Zi Yan <ziy@...dia.com>
Cc: Zi Yan <zi.yan@...t.com>, linux-mm@...ck.org,
 linux-kernel@...r.kernel.org, "Huang, Ying" <ying.huang@...el.com>, Ryan
 Roberts <ryan.roberts@....com>, "Matthew Wilcox (Oracle)"
 <willy@...radead.org>, David Hildenbrand <david@...hat.com>, "Yin, Fengwei"
 <fengwei.yin@...el.com>, Yu Zhao <yuzhao@...gle.com>, Vlastimil Babka
 <vbabka@...e.cz>, "Kirill A . Shutemov" <kirill.shutemov@...ux.intel.com>,
 Johannes Weiner <hannes@...xchg.org>, Baolin Wang
 <baolin.wang@...ux.alibaba.com>, Kemeng Shi <shikemeng@...weicloud.com>,
 Mel Gorman <mgorman@...hsingularity.net>, Rohan Puri
 <rohan.puri15@...il.com>, Mcgrof Chamberlain <mcgrof@...nel.org>, Adam
 Manzanares <a.manzanares@...sung.com>, "Vishal Moola (Oracle)"
 <vishal.moola@...il.com>
Subject: Re: [PATCH v6 0/4] Enable >0 order folio memory compaction

On Fri, 16 Feb 2024 12:04:28 -0500 Zi Yan <zi.yan@...t.com> wrote:

> Baolin's patch

Baolin writes many patches and patches have names, please use them!

> on nr_migratepages was based on this one, a better fixup
> for it might be below. Since before my patchset, compaction only deals with
> order-0 pages.

I don't understand what this means.  The patchset you sent applies OK
to mm-unstable so what else is there to do?

> diff --git a/mm/compaction.c b/mm/compaction.c
> index 01ec85cfd623f..e60135e2019d6 100644
> --- a/mm/compaction.c
> +++ b/mm/compaction.c
> @@ -1798,7 +1798,7 @@ static struct folio *compaction_alloc(struct folio *src, unsigned long data)
>  	dst = list_entry(cc->freepages.next, struct folio, lru);
>  	list_del(&dst->lru);
>  	cc->nr_freepages--;
> -	cc->nr_migratepages -= 1 << order;
> +	cc->nr_migratepages--;
>  
>  	return dst;
>  }
> @@ -1814,7 +1814,7 @@ static void compaction_free(struct folio *dst, unsigned long data)
>  
>  	list_add(&dst->lru, &cc->freepages);
>  	cc->nr_freepages++;
> -	cc->nr_migratepages += 1 << order;
> +	cc->nr_migratepages++;
>  }