linux-kernel - Re: [PATCH v8 2/4] mm: introduce new flag to indicate wc safe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <SA1PR12MB719965C8386AB1A309397B49B0502@SA1PR12MB7199.namprd12.prod.outlook.com>
Date: Tue, 20 Feb 2024 09:40:31 +0000
From: Ankit Agrawal <ankita@...dia.com>
To: Zhi Wang <zhiw@...dia.com>, David Hildenbrand <david@...hat.com>, Jason
 Gunthorpe <jgg@...dia.com>, "maz@...nel.org" <maz@...nel.org>,
	"oliver.upton@...ux.dev" <oliver.upton@...ux.dev>, "james.morse@....com"
	<james.morse@....com>, "suzuki.poulose@....com" <suzuki.poulose@....com>,
	"yuzenghui@...wei.com" <yuzenghui@...wei.com>, "reinette.chatre@...el.com"
	<reinette.chatre@...el.com>, "surenb@...gle.com" <surenb@...gle.com>,
	"stefanha@...hat.com" <stefanha@...hat.com>, "brauner@...nel.org"
	<brauner@...nel.org>, "catalin.marinas@....com" <catalin.marinas@....com>,
	"will@...nel.org" <will@...nel.org>, "mark.rutland@....com"
	<mark.rutland@....com>, "alex.williamson@...hat.com"
	<alex.williamson@...hat.com>, "kevin.tian@...el.com" <kevin.tian@...el.com>,
	"yi.l.liu@...el.com" <yi.l.liu@...el.com>, "ardb@...nel.org"
	<ardb@...nel.org>, "akpm@...ux-foundation.org" <akpm@...ux-foundation.org>,
	"andreyknvl@...il.com" <andreyknvl@...il.com>, "wangjinchao@...sion.com"
	<wangjinchao@...sion.com>, "gshan@...hat.com" <gshan@...hat.com>,
	"shahuang@...hat.com" <shahuang@...hat.com>, "ricarkol@...gle.com"
	<ricarkol@...gle.com>, "linux-mm@...ck.org" <linux-mm@...ck.org>,
	"lpieralisi@...nel.org" <lpieralisi@...nel.org>, "rananta@...gle.com"
	<rananta@...gle.com>, "ryan.roberts@....com" <ryan.roberts@....com>,
	"linus.walleij@...aro.org" <linus.walleij@...aro.org>, "bhe@...hat.com"
	<bhe@...hat.com>
CC: Aniket Agashe <aniketa@...dia.com>, Neo Jia <cjia@...dia.com>, Kirti
 Wankhede <kwankhede@...dia.com>, "Tarun Gupta (SW-GPU)"
	<targupta@...dia.com>, Vikram Sethi <vsethi@...dia.com>, Andy Currid
	<ACurrid@...dia.com>, Alistair Popple <apopple@...dia.com>, John Hubbard
	<jhubbard@...dia.com>, Dan Williams <danw@...dia.com>,
	"kvmarm@...ts.linux.dev" <kvmarm@...ts.linux.dev>, Matt Ochs
	<mochs@...dia.com>, "kvm@...r.kernel.org" <kvm@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH v8 2/4] mm: introduce new flag to indicate wc safe

>>>>> To safely use VFIO in KVM the platform must guarantee full safety in
>>>>> the
>>>>> guest where no action taken against a MMIO mapping can trigger an
>>>>> uncontained failure. We belive that most VFIO PCI platforms support
>>>>> this
>>>>
>>>> A nit, let's use passive voice in the patch comment. Also belive is
>>>> mostly
>>>> a typo.
>>>
>>> Sure, will do.
>>>
>>
>> s/we expect/the expectation is that/
>> s/We belive/The assumption is/
>>
>> If it's just that, likely no need to resend. Maintainers usually can fix
>> that up when applying (otherwise, they'll let you know :) ).
>>
> Many thanks! :)

Good to know, thanks David.