linux-kernel - [PATCH] scsi: ufs: core: Fix mcq mac configuration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240220095637.2900067-1-rohitner@google.com>
Date: Tue, 20 Feb 2024 01:56:37 -0800
From: Rohit Ner <rohitner@...gle.com>
To: Can Guo <quic_cang@...cinc.com>, Bean Huo <beanhuo@...ron.com>, 
	Bart Van Assche <bvanassche@....org>, "Martin K. Petersen" <martin.petersen@...cle.com>
Cc: Avri Altman <avri.altman@....com>, "Bao D. Nguyen" <quic_nguyenb@...cinc.com>, 
	linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org, 
	Rohit Ner <rohitner@...gle.com>
Subject: [PATCH] scsi: ufs: core: Fix mcq mac configuration

As per JEDEC Standard No. 223E Section 5.9.2,
the max # active commands value programmed by the host sw
in MCQConfig.MAC should be one less than the actual value.

Signed-off-by: Rohit Ner <rohitner@...gle.com>
---
 drivers/ufs/core/ufs-mcq.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/ufs/core/ufs-mcq.c b/drivers/ufs/core/ufs-mcq.c
index 0787456c2b89..c873fd823942 100644
--- a/drivers/ufs/core/ufs-mcq.c
+++ b/drivers/ufs/core/ufs-mcq.c
@@ -94,7 +94,7 @@ void ufshcd_mcq_config_mac(struct ufs_hba *hba, u32 max_active_cmds)
 
 	val = ufshcd_readl(hba, REG_UFS_MCQ_CFG);
 	val &= ~MCQ_CFG_MAC_MASK;
-	val |= FIELD_PREP(MCQ_CFG_MAC_MASK, max_active_cmds);
+	val |= FIELD_PREP(MCQ_CFG_MAC_MASK, max_active_cmds - 1);
 	ufshcd_writel(hba, val, REG_UFS_MCQ_CFG);
 }
 EXPORT_SYMBOL_GPL(ufshcd_mcq_config_mac);
-- 
2.44.0.rc0.258.g7320e95886-goog