[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20240220105824.76556c51@xps-13>
Date: Tue, 20 Feb 2024 10:58:24 +0100
From: Miquel Raynal <miquel.raynal@...tlin.com>
To: William Zhang <william.zhang@...adcom.com>
Cc: Linux MTD List <linux-mtd@...ts.infradead.org>, Linux ARM List
<linux-arm-kernel@...ts.infradead.org>, Broadcom Kernel List
<bcm-kernel-feedback-list@...adcom.com>, f.fainelli@...il.com,
kursad.oney@...adcom.com, joel.peshkin@...adcom.com,
anand.gore@...adcom.com, dregan@...l.com, kamal.dasu@...adcom.com,
tomer.yacoby@...adcom.com, dan.beygelman@...adcom.com, David Regan
<dregan@...adcom.com>, linux-kernel@...r.kernel.org, Vignesh Raghavendra
<vigneshr@...com>, Brian Norris <computersforpeace@...il.com>, Richard
Weinberger <richard@....at>
Subject: Re: [PATCH v5 09/12] mtd: rawnand: brcmnand: Add support for
getting ecc setting from strap
Hi William,
william.zhang@...adcom.com wrote on Wed, 7 Feb 2024 12:22:54 -0800:
> BCMBCA broadband SoC based board design does not specify ecc setting in
> dts but rather use the SoC NAND strap info to obtain the ecc strength
> and spare area size setting. Add brcm,nand-ecc-use-strap dts propety for
> this purpose and update driver to support this option.
>
> The generic nand ecc settings still take precedence over this flag. For
And this sentence can also be dropped. Please mention they cannot be
used at the same time.
> example, if nand-ecc-strength is set in the dts, the driver ignores the
> strap setting and falls back to original behavior. This makes sure that
> the existing BCMBCA board dts still works the old way even the strap
> flag is set in the BCMBCA chip dtsi.
I think I already said this was a bad idea IMHO :-)
Thanks,
Miquèl
Powered by blists - more mailing lists