[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <7df55836-f782-3765-d8eb-67b6ae6a3bc4@arm.com>
Date: Tue, 20 Feb 2024 10:16:29 +0000
From: James Clark <james.clark@....com>
To: Chaitanya S Prakash <ChaitanyaS.Prakash@....com>,
linux-perf-users@...r.kernel.org
Cc: anshuman.khandual@....com, Peter Zijlstra <peterz@...radead.org>,
Ingo Molnar <mingo@...hat.com>, Arnaldo Carvalho de Melo <acme@...nel.org>,
Namhyung Kim <namhyung@...nel.org>, Mark Rutland <mark.rutland@....com>,
Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
Jiri Olsa <jolsa@...nel.org>, Ian Rogers <irogers@...gle.com>,
Adrian Hunter <adrian.hunter@...el.com>, Georg Müller
<georgmueller@....net>, Masami Hiramatsu <mhiramat@...nel.org>,
Liam Howlett <liam.howlett@...cle.com>,
Athira Rajeev <atrajeev@...ux.vnet.ibm.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/3] perf tools: Fix test "perf probe of function from
different CU"
On 20/02/2024 04:29, Chaitanya S Prakash wrote:
> From: Chaitanya S Prakash <chaitanyas.prakash@....com>
>
> Defconfig doesn't provide all the necessary configs required for the
> test "perf probe of function from different CU" to run successfully on
> all platforms. Therefore the required configs have been added to
> config fragments to resolve this issue. On further investigation it was
> seen that the Perf treated all files beginning with "/tmp/perf-" as a
> map file despite them always ending in ".map", this caused the test to
> fail when Perf was built with NO_DWARF=1. As the file was parsed as a
> map file, the probe...--funcs command output garbage values instead of
> listing the functions in the binary. After fixing the issue an
> additional check to test the output of the probe...--funcs command has
> been added.
>
> This patch series has been tested on 6.8-rc3 mainline kernerl, both on
> arm64 and x86 platforms.
>
> Cc: Peter Zijlstra <peterz@...radead.org>
> Cc: Ingo Molnar <mingo@...hat.com>
> Cc: Arnaldo Carvalho de Melo <acme@...nel.org>
> Cc: Namhyung Kim <namhyung@...nel.org>
> Cc: Mark Rutland <mark.rutland@....com>
> Cc: Alexander Shishkin <alexander.shishkin@...ux.intel.com>
> Cc: Jiri Olsa <jolsa@...nel.org>
> Cc: Ian Rogers <irogers@...gle.com>
> Cc: Adrian Hunter <adrian.hunter@...el.com>
> Cc: James Clark <james.clark@....com>
> Cc: Georg Müller <georgmueller@....net>
> Cc: Masami Hiramatsu <mhiramat@...nel.org>
> Cc: Liam Howlett <liam.howlett@...cle.com>
> Cc: Athira Rajeev <atrajeev@...ux.vnet.ibm.com>
> Cc: linux-perf-users@...r.kernel.org
> Cc: linux-kernel@...r.kernel.org
>
> Chaitanya S Prakash (3):
> perf tools: Enable configs required for
> test_uprobe_from_different_cu.sh
> perf tools: Only treat files as map files when they have the extension
> .map
> perf test: Check output of the probe ... --funcs command
>
> tools/perf/builtin-script.c | 15 +--------------
> tools/perf/tests/config-fragments/config | 3 +++
> .../shell/test_uprobe_from_different_cu.sh | 2 +-
> tools/perf/util/string.c | 18 ++++++++++++++++++
> tools/perf/util/string2.h | 1 +
> tools/perf/util/symbol.c | 5 ++++-
> 6 files changed, 28 insertions(+), 16 deletions(-)
>
Reviewed-by: James Clark <james.clark@....com>
Powered by blists - more mailing lists