linux-kernel - Re: [PATCH v8 4/4] vfio: convey kvm that the vfio-pci device is wc safe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <SA1PR12MB7199A969E2A4B31220EFF152B0502@SA1PR12MB7199.namprd12.prod.outlook.com>
Date: Tue, 20 Feb 2024 12:11:19 +0000
From: Ankit Agrawal <ankita@...dia.com>
To: Catalin Marinas <catalin.marinas@....com>
CC: Jason Gunthorpe <jgg@...dia.com>, "maz@...nel.org" <maz@...nel.org>,
	"oliver.upton@...ux.dev" <oliver.upton@...ux.dev>, "james.morse@....com"
	<james.morse@....com>, "suzuki.poulose@....com" <suzuki.poulose@....com>,
	"yuzenghui@...wei.com" <yuzenghui@...wei.com>, "reinette.chatre@...el.com"
	<reinette.chatre@...el.com>, "surenb@...gle.com" <surenb@...gle.com>,
	"stefanha@...hat.com" <stefanha@...hat.com>, "brauner@...nel.org"
	<brauner@...nel.org>, "will@...nel.org" <will@...nel.org>,
	"mark.rutland@....com" <mark.rutland@....com>, "alex.williamson@...hat.com"
	<alex.williamson@...hat.com>, "kevin.tian@...el.com" <kevin.tian@...el.com>,
	"yi.l.liu@...el.com" <yi.l.liu@...el.com>, "ardb@...nel.org"
	<ardb@...nel.org>, "akpm@...ux-foundation.org" <akpm@...ux-foundation.org>,
	"andreyknvl@...il.com" <andreyknvl@...il.com>, "wangjinchao@...sion.com"
	<wangjinchao@...sion.com>, "gshan@...hat.com" <gshan@...hat.com>,
	"shahuang@...hat.com" <shahuang@...hat.com>, "ricarkol@...gle.com"
	<ricarkol@...gle.com>, "linux-mm@...ck.org" <linux-mm@...ck.org>,
	"lpieralisi@...nel.org" <lpieralisi@...nel.org>, "rananta@...gle.com"
	<rananta@...gle.com>, "ryan.roberts@....com" <ryan.roberts@....com>,
	"david@...hat.com" <david@...hat.com>, "linus.walleij@...aro.org"
	<linus.walleij@...aro.org>, "bhe@...hat.com" <bhe@...hat.com>, Aniket Agashe
	<aniketa@...dia.com>, Neo Jia <cjia@...dia.com>, Kirti Wankhede
	<kwankhede@...dia.com>, "Tarun Gupta (SW-GPU)" <targupta@...dia.com>, Vikram
 Sethi <vsethi@...dia.com>, Andy Currid <acurrid@...dia.com>, Alistair Popple
	<apopple@...dia.com>, John Hubbard <jhubbard@...dia.com>, Dan Williams
	<danw@...dia.com>, "kvmarm@...ts.linux.dev" <kvmarm@...ts.linux.dev>, Matt
 Ochs <mochs@...dia.com>, Zhi Wang <zhiw@...dia.com>, "kvm@...r.kernel.org"
	<kvm@...r.kernel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH v8 4/4] vfio: convey kvm that the vfio-pci device is wc
 safe

>> diff --git a/drivers/vfio/pci/vfio_pci_core.c b/drivers/vfio/pci/vfio_pci_core.c
>> index 1cbc990d42e0..c93bea18fc4b 100644
>> --- a/drivers/vfio/pci/vfio_pci_core.c
>> +++ b/drivers/vfio/pci/vfio_pci_core.c
>> @@ -1862,8 +1862,24 @@ int vfio_pci_core_mmap(struct vfio_device *core_vdev, struct vm_area_struct *vma
>>       /*
>>        * See remap_pfn_range(), called from vfio_pci_fault() but we can't
>>        * change vm_flags within the fault handler.  Set them now.
>> +      *
>> +      * VM_ALLOW_ANY_UNCACHED: The VMA flag is implemented for ARM64,
>> +      * allowing KVM stage 2 device mapping attributes to use Normal-NC
>> +      * rather than DEVICE_nGnRE, which allows guest mappings
>> +      * supporting combining attributes (WC). ARM does not
>
> Nitpick: "supporting write-combining" (if you plan to respin).

Ack.