linux-kernel - Re: [3/6] soc: qcom: pmic_glink_altmode: fix drm bridge use-after-free

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 20 Feb 2024 13:40:20 +0100
From: Markus Elfring <Markus.Elfring@....de>
To: Johan Hovold <johan@...nel.org>, freedreno@...ts.freedesktop.org,
 dri-devel@...ts.freedesktop.org, linux-phy@...ts.infradead.org,
 linux-arm-msm@...r.kernel.org, kernel-janitors@...r.kernel.org
Cc: Johan Hovold <johan+linaro@...nel.org>,
 Andrzej Hajda <andrzej.hajda@...el.com>,
 Bjorn Andersson <andersson@...nel.org>, Daniel Vetter <daniel@...ll.ch>,
 David Airlie <airlied@...il.com>,
 Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
 Maxime Ripard <mripard@...nel.org>,
 Neil Armstrong <neil.armstrong@...aro.org>, Robert Foss <rfoss@...nel.org>,
 Thomas Zimmermann <tzimmermann@...e.de>, Vinod Koul <vkoul@...nel.org>,
 LKML <linux-kernel@...r.kernel.org>,
 Abhinav Kumar <quic_abhinavk@...cinc.com>,
 Dmitry Baryshkov <dmitry.baryshkov@...aro.org>,
 Jernej Skrabec <jernej.skrabec@...il.com>, Jonas Karlman <jonas@...boo.se>,
 Kishon Vijay Abraham I <kishon@...nel.org>,
 Konrad Dybcio <konrad.dybcio@...aro.org>,
 Kuogee Hsieh <quic_khsieh@...cinc.com>,
 Laurent Pinchart <Laurent.pinchart@...asonboard.com>,
 Rob Clark <robdclark@...il.com>, stable@...r.kernel.org
Subject: Re: [3/6] soc: qcom: pmic_glink_altmode: fix drm bridge
 use-after-free

>> The function call “fwnode_handle_put(fwnode)” is used in multiple if branches.
>> https://elixir.bootlin.com/linux/v6.8-rc5/source/drivers/soc/qcom/pmic_glink_altmode.c#L435
>>
>> I suggest to add a jump target so that a bit of exception handling
>> can be better reused at the end of this function implementation.
>
> Markus, as people have told you repeatedly, just stop with these comments.

How does such a response fit to advices from another known information sources?

Section “7) Centralized exiting of functions”
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst?h=v6.8-rc5#n526


> You're not helping, in fact, you are actively harmful to the
> kernel community as you are wasting people's time.

The proposed source code transformation can eventually be (automatically) achieved
also with help of improved development tools.

Regards,
Markus