linux-kernel - Re: [PATCH 1/1] MIPS: move unselectable entries out of the "CPU type" choice

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Tue, 20 Feb 2024 14:38:24 +0100
From: Thomas Bogendoerfer <tsbogend@...ha.franken.de>
To: Masahiro Yamada <masahiroy@...nel.org>
Cc: linux-mips@...r.kernel.org, linux-kbuild@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] MIPS: move unselectable entries out of the "CPU
 type" choice

On Sun, Jan 28, 2024 at 01:23:09AM +0900, Masahiro Yamada wrote:
> Move the following entries out of the "CPU type" choice:
> 
>  - LOONGSON3_ENHANCEMENT
>  - CPU_LOONGSON3_WORKAROUNDS
>  - CPU_LOONGSON3_CPUCFG_EMULATION
> 
> These entries cannot be selected from the choice because they depend on
> CPU_LOONGSON64, which is also located in the same choice.
> 
> In fact, Kconfig does not consider them as choice values because they
> become children of CPU_LOOONGSON64 due to the automatic submenu creation
> in menu_finalize().
> 
> However, it is hard to understand this behavior unless you are familiar
> with the Kconfig internals.
> 
> "choice" should contain only selectable entries.
> 
> Signed-off-by: Masahiro Yamada <masahiroy@...nel.org>
> ---
> 
>  arch/mips/Kconfig | 76 +++++++++++++++++++++++------------------------
>  1 file changed, 38 insertions(+), 38 deletions(-)

applied to mips-next.

Thomas.

-- 
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]