linux-kernel - Re: [PATCH v11 07/14] dt-bindings: imx6q-pcie: Clean up irrationality clocks check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZdYXtmJgTQ63jq+C@lizhi-Precision-Tower-5810>
Date: Wed, 21 Feb 2024 10:33:10 -0500
From: Frank Li <Frank.li@....com>
To: Lorenzo Pieralisi <lpieralisi@...nel.org>
Cc: bhelgaas@...gle.com, cassel@...nel.org, conor+dt@...nel.org,
	devicetree@...r.kernel.org, festevam@...il.com, helgaas@...nel.org,
	hongxing.zhu@....com, imx@...ts.linux.dev, kernel@...gutronix.de,
	krzysztof.kozlowski+dt@...aro.org, krzysztof.kozlowski@...aro.org,
	kw@...ux.com, l.stach@...gutronix.de,
	linux-arm-kernel@...ts.infradead.org, linux-imx@....com,
	linux-kernel@...r.kernel.org, linux-pci@...r.kernel.org,
	manivannan.sadhasivam@...aro.org, robh@...nel.org,
	s.hauer@...gutronix.de, shawnguo@...nel.org
Subject: Re: [PATCH v11 07/14] dt-bindings: imx6q-pcie: Clean up
 irrationality clocks check

On Wed, Feb 21, 2024 at 11:49:27AM +0100, Lorenzo Pieralisi wrote:
> Irrationality ? I think you mean "duplicate" or "redundant" ?

I initially emphasized the negation logic code (*not*) below. I may have
used the wrong term.

I am okay simple said
"Clean up redundant clocks check"

Frank 

> 
> Lorenzo
> 
> On Tue, Feb 20, 2024 at 11:19:17AM -0500, Frank Li wrote:
> > The bindings referencing this file already define these constraints for
> > each of the variants, so the if not: then: is redundant.
> > 
> > Acked-by: Rob Herring <robh@...nel.org>
> > Acked-by: Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>
> > Signed-off-by: Frank Li <Frank.Li@....com>
> > ---
> > 
> > Notes:
> >     Change from v7 to v8
> >     - add Manivannan Sadhasiva's Ack tag
> >     Change from v6 to v7
> >     - rewrite git commit message by using simple words
> >     Change from v5 to v6
> >     - rewrite git commit message and explain why remove it safely.
> >     - Add Rob's Ack
> >     Change from v1 to v4
> >     - new patch at v4
> > 
> >  .../bindings/pci/fsl,imx6q-pcie-common.yaml      | 16 ----------------
> >  1 file changed, 16 deletions(-)
> > 
> > diff --git a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie-common.yaml b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie-common.yaml
> > index d91b639ae7ae7..0c50487a3866d 100644
> > --- a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie-common.yaml
> > +++ b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie-common.yaml
> > @@ -150,22 +150,6 @@ allOf:
> >              - {}
> >              - const: pcie_phy
> >              - const: pcie_aux
> > -  - if:
> > -      properties:
> > -        compatible:
> > -          not:
> > -            contains:
> > -              enum:
> > -                - fsl,imx6sx-pcie
> > -                - fsl,imx8mq-pcie
> > -                - fsl,imx6sx-pcie-ep
> > -                - fsl,imx8mq-pcie-ep
> > -    then:
> > -      properties:
> > -        clocks:
> > -          maxItems: 3
> > -        clock-names:
> > -          maxItems: 3
> >  
> >    - if:
> >        properties:
> > -- 
> > 2.34.1
> >