linux-kernel - Re: [PATCH] ASoC: qcom: Fix uninitialized pointer dmactl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <170853137427.40410.4918124750403655559.b4-ty@kernel.org>
Date: Wed, 21 Feb 2024 16:02:54 +0000
From: Mark Brown <broonie@...nel.org>
To: Srinivas Kandagatla <srinivas.kandagatla@...aro.org>, 
 Banajit Goswami <bgoswami@...cinc.com>, Liam Girdwood <lgirdwood@...il.com>, 
 Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>, 
 Srinivasa Rao Mandadapu <quic_srivasam@...cinc.com>, 
 Venkata Prasad Potturu <quic_potturu@...cinc.com>, 
 alsa-devel@...a-project.org, linux-sound@...r.kernel.org, 
 Colin Ian King <colin.i.king@...il.com>
Cc: kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ASoC: qcom: Fix uninitialized pointer dmactl

On Wed, 21 Feb 2024 13:48:04 +0000, Colin Ian King wrote:
> In the case where __lpass_get_dmactl_handle is called and the driver
> id dai_id is invalid the pointer dmactl is not being assigned a value,
> and dmactl contains a garbage value since it has not been initialized
> and so the null check may not work. Fix this to initialize dmactl to
> NULL. One could argue that modern compilers will set this to zero, but
> it is useful to keep this initialized as per the same way in functions
> __lpass_platform_codec_intf_init and lpass_cdc_dma_daiops_hw_params.
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: qcom: Fix uninitialized pointer dmactl
      commit: 1382d8b55129875b2e07c4d2a7ebc790183769ee

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark