linux-kernel - Re: [PATCH v3] x86/coco: Require seeding RNG with RDRAND on CoCo systems

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <eada8acd-9341-401b-b6c9-a05848eb91d6@intel.com>
Date: Wed, 21 Feb 2024 08:55:26 -0800
From: Dave Hansen <dave.hansen@...el.com>
To: "Jason A. Donenfeld" <Jason@...c4.com>, x86@...nel.org,
 linux-coco@...ts.linux.dev, linux-kernel@...r.kernel.org
Cc: Borislav Petkov <bp@...en8.de>, Daniel P . Berrangé
 <berrange@...hat.com>, Dave Hansen <dave.hansen@...ux.intel.com>,
 Elena Reshetova <elena.reshetova@...el.com>, "H . Peter Anvin"
 <hpa@...or.com>, Ingo Molnar <mingo@...hat.com>,
 "Kirill A . Shutemov" <kirill.shutemov@...ux.intel.com>,
 Theodore Ts'o <tytso@....edu>, Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [PATCH v3] x86/coco: Require seeding RNG with RDRAND on CoCo
 systems

On 2/21/24 04:32, Jason A. Donenfeld wrote:
> +__init void cc_random_init(void)
> +{
> +	unsigned long rng_seed[32 / sizeof(long)];

My only nit with this is the magic "32".

Why not 16?  Or 64?