Date: Wed, 21 Feb 2024 17:57:05 +0000
From: Maxwell Bland <mbland@...orola.com>
To: Christophe Leroy <christophe.leroy@...roup.eu>,
        "linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org>
CC: "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "agordeev@...ux.ibm.com" <agordeev@...ux.ibm.com>,
        "akpm@...ux-foundation.org" <akpm@...ux-foundation.org>,
        "andreyknvl@...il.com" <andreyknvl@...il.com>,
        "andrii@...nel.org"
	<andrii@...nel.org>,
        "aneesh.kumar@...nel.org" <aneesh.kumar@...nel.org>,
        "aou@...s.berkeley.edu" <aou@...s.berkeley.edu>,
        "ardb@...nel.org"
	<ardb@...nel.org>, "arnd@...db.de" <arnd@...db.de>,
        "ast@...nel.org"
	<ast@...nel.org>,
        "borntraeger@...ux.ibm.com" <borntraeger@...ux.ibm.com>,
        "bpf@...r.kernel.org" <bpf@...r.kernel.org>,
        "brauner@...nel.org"
	<brauner@...nel.org>,
        "catalin.marinas@....com" <catalin.marinas@....com>,
        "cl@...ux.com" <cl@...ux.com>,
        "daniel@...earbox.net" <daniel@...earbox.net>,
        "dave.hansen@...ux.intel.com" <dave.hansen@...ux.intel.com>,
        "david@...hat.com" <david@...hat.com>,
        "dennis@...nel.org"
	<dennis@...nel.org>,
        "dvyukov@...gle.com" <dvyukov@...gle.com>,
        "glider@...gle.com" <glider@...gle.com>,
        "gor@...ux.ibm.com"
	<gor@...ux.ibm.com>,
        "guoren@...nel.org" <guoren@...nel.org>,
        "haoluo@...gle.com" <haoluo@...gle.com>,
        "hca@...ux.ibm.com"
	<hca@...ux.ibm.com>,
        "hch@...radead.org" <hch@...radead.org>,
        "john.fastabend@...il.com" <john.fastabend@...il.com>,
        "jolsa@...nel.org"
	<jolsa@...nel.org>,
        "kasan-dev@...glegroups.com"
	<kasan-dev@...glegroups.com>,
        "kpsingh@...nel.org" <kpsingh@...nel.org>,
        "linux-arch@...r.kernel.org" <linux-arch@...r.kernel.org>,
        "linux@...linux.org.uk" <linux@...linux.org.uk>,
        "linux-efi@...r.kernel.org"
	<linux-efi@...r.kernel.org>,
        "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>,
        "linux-mm@...ck.org" <linux-mm@...ck.org>,
        "linuxppc-dev@...ts.ozlabs.org" <linuxppc-dev@...ts.ozlabs.org>,
        "linux-riscv@...ts.infradead.org" <linux-riscv@...ts.infradead.org>,
        "linux-s390@...r.kernel.org" <linux-s390@...r.kernel.org>,
        "lstoakes@...il.com" <lstoakes@...il.com>,
        "mark.rutland@....com"
	<mark.rutland@....com>,
        "martin.lau@...ux.dev" <martin.lau@...ux.dev>,
        "meted@...ux.ibm.com" <meted@...ux.ibm.com>,
        "michael.christie@...cle.com"
	<michael.christie@...cle.com>,
        "mjguzik@...il.com" <mjguzik@...il.com>,
        "mpe@...erman.id.au" <mpe@...erman.id.au>,
        "mst@...hat.com" <mst@...hat.com>,
        "muchun.song@...ux.dev" <muchun.song@...ux.dev>,
        "naveen.n.rao@...ux.ibm.com"
	<naveen.n.rao@...ux.ibm.com>,
        "npiggin@...il.com" <npiggin@...il.com>,
        "palmer@...belt.com" <palmer@...belt.com>,
        "paul.walmsley@...ive.com"
	<paul.walmsley@...ive.com>,
        "quic_nprakash@...cinc.com"
	<quic_nprakash@...cinc.com>,
        "quic_pkondeti@...cinc.com"
	<quic_pkondeti@...cinc.com>,
        "rick.p.edgecombe@...el.com"
	<rick.p.edgecombe@...el.com>,
        "ryabinin.a.a@...il.com"
	<ryabinin.a.a@...il.com>,
        "ryan.roberts@....com" <ryan.roberts@....com>,
        "samitolvanen@...gle.com" <samitolvanen@...gle.com>,
        "sdf@...gle.com"
	<sdf@...gle.com>,
        "song@...nel.org" <song@...nel.org>,
        "surenb@...gle.com"
	<surenb@...gle.com>,
        "svens@...ux.ibm.com" <svens@...ux.ibm.com>,
        "tj@...nel.org" <tj@...nel.org>, "urezki@...il.com" <urezki@...il.com>,
        "vincenzo.frascino@....com" <vincenzo.frascino@....com>,
        "will@...nel.org"
	<will@...nel.org>,
        "wuqiang.matt@...edance.com" <wuqiang.matt@...edance.com>,
        "yonghong.song@...ux.dev" <yonghong.song@...ux.dev>,
        "zlim.lnx@...il.com"
	<zlim.lnx@...il.com>,
        Andrew Wheeler <awheeler@...orola.com>
Subject: Re: [PATCH 0/4] arm64: mm: support dynamic vmalloc/pmd configuration

> On Wednesday, February 21, 2024 at 1:32 AM, Christophe Leroy wrote:
> 
> On powerpc (book3s/32) we have more or less the same although it is not
> directly linked to PMDs: the virtual 4G address space is split in
> segments of 256M. On each segment there's a bit called NX to forbit
> execution. Vmalloc space is allocated in a segment with NX bit set while
> Module spare is allocated in a segment with NX bit unset. We never have
> to override vmalloc wrappers. All consumers of exec memory allocate it
> using module_alloc() while vmalloc() provides non-exec memory.
> 
> For modules, all you have to do is select
> ARCH_WANTS_MODULES_DATA_IN_VMALLOC and module data will be allocated
> using vmalloc() hence non-exec memory in our case.

This critique has led me to some valuable ideas, and I can definitely find a simpler
approach without overrides.

I do want to mention changes to how VMALLOC_* and MODULE_* constants
are used on arm64 may introduce other issues. See discussion/code on the patch
that motivated this patch at:

https://lore.kernel.org/all/CAP5Mv+ydhk=Ob4b40ZahGMgT-5+-VEHxtmA=-LkJiEOOU+K6hw@mail.gmail.com/

In short, maybe the issue of code/data intermixing requires a rework of arm64
memory infrastructure, but I see a potentially elegant solution here based on the
comments given on this patch.

Thanks,
Maxwell

Powered by blists - more mailing lists