linux-kernel - Re: [PATCH 04/11] misc: hisi_hikey_usb: Convert to platform remove callback returning void

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANDhNCpURMQmRwCyt47SnSWJO=uJiaWNr9QVmmAMBZ7r5JhJMA@mail.gmail.com>
Date: Wed, 21 Feb 2024 11:16:03 -0800
From: John Stultz <jstultz@...gle.com>
To: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
Cc: Arnd Bergmann <arnd@...db.de>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, kernel@...gutronix.de, 
	linux-kernel@...r.kernel.org, Yongqin Liu <yongqin.liu@...aro.org>, 
	Sumit Semwal <sumit.semwal@...aro.org>
Subject: Re: [PATCH 04/11] misc: hisi_hikey_usb: Convert to platform remove
 callback returning void

On Wed, Feb 21, 2024 at 1:54 AM Uwe Kleine-König
<u.kleine-koenig@...gutronix.de> wrote:
>
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is ignored (apart
> from emitting a warning) and this typically results in resource leaks.
>
> To improve here there is a quest to make the remove callback return
> void. In the first step of this quest all drivers are converted to
> .remove_new(), which already returns void. Eventually after all drivers
> are converted, .remove_new() will be renamed to .remove().
>
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>

Looks fine to me.
Acked-by: John Stultz <jstultz@...gle.com>

CC'ing YongQin as he still has hardware to test with.

thanks
-john