linux-kernel - Re: [PATCH] mm/mmu_gather: change __tlb_remove_tlb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <edebfa0b-7955-41c0-89d2-8a86fd3d0c55@redhat.com>
Date: Wed, 21 Feb 2024 20:30:53 +0100
From: David Hildenbrand <david@...hat.com>
To: Arnd Bergmann <arnd@...nel.org>, Andrew Morton <akpm@...ux-foundation.org>
Cc: Arnd Bergmann <arnd@...db.de>, Will Deacon <will@...nel.org>,
 "Aneesh Kumar K.V" <aneesh.kumar@...ux.ibm.com>,
 Nick Piggin <npiggin@...il.com>, Peter Zijlstra <peterz@...radead.org>,
 Nathan Chancellor <nathan@...nel.org>,
 Nick Desaulniers <ndesaulniers@...gle.com>, Bill Wendling
 <morbo@...gle.com>, Justin Stitt <justinstitt@...gle.com>,
 Ryan Roberts <ryan.roberts@....com>,
 "Vishal Moola (Oracle)" <vishal.moola@...il.com>,
 Alistair Popple <apopple@...dia.com>, linux-arch@...r.kernel.org,
 linux-mm@...ck.org, linux-kernel@...r.kernel.org, llvm@...ts.linux.dev
Subject: Re: [PATCH] mm/mmu_gather: change __tlb_remove_tlb_entry() to an
 inline function

On 21.02.24 16:45, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@...db.de>
> 

Hi Arnd,

> clang complains about tlb_remove_tlb_entries() not using the 'ptep' variable
> when __tlb_remove_tlb_entry() is an empty macro:
> 
> include/asm-generic/tlb.h:627:10: error: parameter 'ptep' set but not used [-Werror,-Wunused-but-set-parameter]
> 
> Change it to an equivalent inline function that avoids the warning since
> the compiler can see how the variable gets passed into it.
> 

Ugh, quite an annoying clang behavior in this particular case. I wonder 
why no build bot complained so far.

Thanks!

> Fixes: 66958b447695 ("mm/mmu_gather: add tlb_remove_tlb_entries()")

That commit id is not stable yet. So Andrew might want to fold it into 
that commit before moving it to mm-stable.


-- 
Cheers,

David / dhildenb