linux-kernel - Re: Re: [PATCH] drm/xe: skip building debugfs code for CONFIG_DEBUG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ngu6vq5izal6suyr57p4vlxnrn4kxyii4ewdktxvw7k3uezlcz@6oevav3wpcjh>
Date: Tue, 20 Feb 2024 23:29:54 -0600
From: Lucas De Marchi <lucas.demarchi@...el.com>
To: Arnd Bergmann <arnd@...db.de>
CC: Jani Nikula <jani.nikula@...ux.intel.com>, Arnd Bergmann
	<arnd@...nel.org>, Oded Gabbay <ogabbay@...nel.org>, Thomas
 Hellström <thomas.hellstrom@...ux.intel.com>, "Maarten
 Lankhorst" <maarten.lankhorst@...ux.intel.com>, Maxime Ripard
	<mripard@...nel.org>, Thomas Zimmermann <tzimmermann@...e.de>, Dave Airlie
	<airlied@...il.com>, Daniel Vetter <daniel@...ll.ch>, Rodrigo Vivi
	<rodrigo.vivi@...el.com>, Matt Roper <matthew.d.roper@...el.com>, "Matthew
 Brost" <matthew.brost@...el.com>, Riana Tauro <riana.tauro@...el.com>,
	"Daniele Ceraolo Spurio" <daniele.ceraolospurio@...el.com>,
	<intel-xe@...ts.freedesktop.org>, <dri-devel@...ts.freedesktop.org>,
	<linux-kernel@...r.kernel.org>, Stephen Rothwell <sfr@...hwell.id.au>
Subject: Re: Re: [PATCH] drm/xe: skip building debugfs code for
 CONFIG_DEBUG_FS=n

+Stephen

On Tue, Feb 13, 2024 at 03:58:54PM +0100, Arnd Bergmann wrote:
>On Tue, Feb 13, 2024, at 15:55, Jani Nikula wrote:
>> On Tue, 13 Feb 2024, Arnd Bergmann <arnd@...nel.org> wrote:
>>> From: Arnd Bergmann <arnd@...db.de>
>>>
>>> Some of the debugfs functions are stubbed out in these configurations,
>>> so trying to build the .c file with the definition fails:
>>>
>>> In file included from include/uapi/linux/posix_types.h:5,
>>>                  from drivers/gpu/drm/i915/display/intel_pipe_crc.c:27:
>>> drivers/gpu/drm/i915/display/intel_pipe_crc.c: At top level:
>>> include/linux/stddef.h:8:16: error: expected identifier or '(' before 'void'
>>>     8 | #define NULL ((void *)0)
>>>       |                ^~~~
>>> drivers/gpu/drm/i915/display/intel_pipe_crc.c:549:20: note: in expansion of macro 'intel_crtc_get_crc_sources'
>>>   549 | const char *const *intel_crtc_get_crc_sources(struct drm_crtc *crtc,
>>>       |                    ^~~~~~~~~~~~~~~~~~~~~~~~~~
>>>
>>> Stop trying to build them by making the Makefile entries conditional,
>>> same as for the i915 driver.
>>
>> Already fixed by commit 439987f6f471 ("drm/xe: don't build debugfs files
>> when CONFIG_DEBUG_FS=n") in drm-xe-next.
>>
>> Maybe that needs to be picked up for -fixes?
>
>I made sure that this still happens in linux-next today, but
>it does not seem to contain 439987f6f471.

Looking at https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=2d5c7b7eb345249cb34d42cbc2b97b4c57ea944e
it seems we still don't have drm-xe-next branch in linux-next.

Stephen, could you please add it? Or do I have to do something on my end
before that?  This is the branch:

https://gitlab.freedesktop.org/drm/xe/kernel drm-xe-next

thanks
Lucas De Marchi



>
>     Arnd