linux-kernel - Re: [Resend PATCHv9 1/1] block: introduce content activity based ioprio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGWkznHTY-ROF-D2w8BjGabfzw1yAqoGsHz321BUKrRBcWuqaw@mail.gmail.com>
Date: Wed, 21 Feb 2024 13:50:55 +0800
From: Zhaoyang Huang <huangzhaoyang@...il.com>
To: Eric Biggers <ebiggers@...nel.org>
Cc: "zhaoyang.huang" <zhaoyang.huang@...soc.com>, Jens Axboe <axboe@...nel.dk>, 
	linux-block@...r.kernel.org, linux-kernel@...r.kernel.org, 
	steve.kang@...soc.com
Subject: Re: [Resend PATCHv9 1/1] block: introduce content activity based ioprio

On Wed, Feb 21, 2024 at 1:41 PM Eric Biggers <ebiggers@...nel.org> wrote:
>
> On Wed, Feb 21, 2024 at 01:26:24PM +0800, zhaoyang.huang wrote:
> > +/*
> > + * bio_set_active_ioprio_folio is helper function to count the bio's
> > + * content's activities which measured by MGLRU.
> > + * The file system should call this function after bio_add_page/folio for
> > + * the buffered read/write/sync.
> > + */
> > +#ifdef CONFIG_BLK_CONT_ACT_BASED_IOPRIO
> > +void bio_set_active_ioprio_folio(struct bio *bio, struct folio *folio)
>
> How did you test this?  Nothing calls this function, so this patch can't
> actually be doing anything.  Are you planning to update any filesystems to use
> this?
Thanks for asking. I verified this patch in an Android based 6GB RAM
system by modifying EROFS/F2FS/EXT4's aops API which I didn't
upstreaming yet. I would like to recommend this to the desired fs if
this is accepted.
>
> - Eric