linux-kernel - Re: [PATCH v5 11/12] mtd: rawnand: brcmnand: exec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f6e61482-b51a-4970-9257-8db7975148fa@moroto.mountain>
Date: Wed, 21 Feb 2024 09:16:31 +0300
From: Dan Carpenter <dan.carpenter@...aro.org>
To: Miquel Raynal <miquel.raynal@...tlin.com>
Cc: William Zhang <william.zhang@...adcom.com>,
	Linux MTD List <linux-mtd@...ts.infradead.org>,
	Linux ARM List <linux-arm-kernel@...ts.infradead.org>,
	Broadcom Kernel List <bcm-kernel-feedback-list@...adcom.com>,
	f.fainelli@...il.com, kursad.oney@...adcom.com,
	joel.peshkin@...adcom.com, anand.gore@...adcom.com, dregan@...l.com,
	kamal.dasu@...adcom.com, tomer.yacoby@...adcom.com,
	dan.beygelman@...adcom.com, David Regan <dregan@...adcom.com>,
	linux-kernel@...r.kernel.org, Vignesh Raghavendra <vigneshr@...com>,
	Brian Norris <computersforpeace@...il.com>,
	Richard Weinberger <richard@....at>
Subject: Re: [PATCH v5 11/12] mtd: rawnand: brcmnand: exec_op helper
 functions return type fixes

On Tue, Feb 20, 2024 at 11:02:40AM +0100, Miquel Raynal wrote:
> 
> william.zhang@...adcom.com wrote on Wed,  7 Feb 2024 12:22:56 -0800:
> 
> > From: David Regan <dregan@...adcom.com>
> > 
> > fix return type for exec_op reset and status detect helper functions
> > 
> > Reported-by: Dan Carpenter <dan.carpenter@...aro.org>
> > Closes: http://lists.infradead.org/pipermail/linux-mtd/2023-December/102423.html
> > Fixes: 3c8260ce7663 ("mtd: rawnand: brcmnand: exec_op implementation")
> > Signed-off-by: David Regan <dregan@...adcom.com>
> > Signed-off-by: William Zhang <william.zhang@...adcom.com>
> > Reviewed-by: William Zhang <william.zhang@...adcom.com>
> 
> By the way, a Cc: stable tag might be useful as otherwise you may leak
> an error code in a status value (which is a bug). And move this patch
> first in your series so we're sure it does not conflict with any of the
> other patches and can be backported more easily.

The original commit 3c8260ce7663 ("mtd: rawnand: brcmnand: exec_op
implementation") is not in stable so we should be okay on this.

regards,
dan carpenter