Message-ID: <c6dbbb75-a67e-485f-8e00-3be05fb53b7f@linaro.org>
Date: Wed, 21 Feb 2024 08:33:03 +0100
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Shenghao Ding <shenghao-ding@...com>, linux-kernel@...r.kernel.org
Cc: lgirdwood@...il.com, broonie@...nel.org, robh+dt@...nel.org,
 krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org,
 linux-sound@...r.kernel.org, devicetree@...r.kernel.org, perex@...ex.cz,
 tiwai@...e.com, 13916275206@....com, mohit.chawla@...com, soyer@....hu,
 jkhuang3@...com, tiwai@...e.de, pdjuandi@...com, manisha.agrawal@...com,
 s-hari@...com, aviel@...com, hnagalla@...com, praneeth@...com
Subject: Re: [PATCH v5 4/4] ASoc: dt-bindings: PCM6240: Add initial DT binding

On 21/02/2024 06:15, Shenghao Ding wrote:
> PCM6240 family chips are popular among audio customers, in spite of only a
> portion of the functionality of codec, such as ADC or DAC, and so on, for
> different Specifications, range from Personal Electric to Automotive
> Electric, even some professional fields. Yet their audio performance is far
> superior to the codec's, and cost is lower than codec, and much easier to
> program than codec.
> 
> Signed-off-by: Shenghao Ding <shenghao-ding@...com>
> 
> ---
> Change in v5:

?!? You got review which you ignored. Now you rewrite everything?

>  - Rewrite the subject to match something similar to other commits.
>  - And none of them are compatible with something.
>  - minItems, then maxItems.
>  - Drop reset-gpios description
>  - Remove the repeated reg descriptions and reg constraints.
>  - Drop redundant spaces.
>  - Add missing line breaks between blocks and additionalProperties.
>  - Correct compatibility issue on adc6120 and pcm6240.
>  - All these chips have only a portion of the functionality of codec,
>    such as ADC or DAC, and so on, but their audio performance is far
>    superior to the codec's, and cost is lower than codec, and much easier
>    to program than codec. Simply one or two register settings can enable
>    them to work. Init for these chips are hardware reset or software reset.
>    As to some audio filter params for internal filters, it is up to the
>    special user cases, which can be saved into the bin file. The default
>    value also can work well.
>  - Add blank line before reg.
>  - remove unneeded items and if branches.
>  - Add missing compatible devices, such as adc6120, etc.
>  - Add necessary people into the list for DTS review
>  - correct misaligned.
>  - simplify the compatibility
>  - Add sound-name-prefix

Didn't you do all this?

..

> +  interrupts:
> +    maxItems: 1
> +    description:
> +      Invalid only for ti,pcm1690 because of no INT pin.
> +
> +  sound-name-prefix: true

Drop

> +
> +  '#sound-dai-cells':
> +    const: 0
> +
> +required:
> +  - compatible
> +  - reg
> +
> +allOf:
> +  - $ref: dai-common.yaml#
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            enum:
> +              - ti,pcm1690
> +    then:
> +      properties:
> +        interrupts: false
> +
> +additionalProperties: false

unevaluatedProperties
> +
> +examples:
> +  - |
> +   #include <dt-bindings/gpio/gpio.h>
> +   i2c {


This is a friendly reminder during the review process.

It looks like you received a tag and forgot to add it.

If you do not know the process, here is a short explanation:
Please add Acked-by/Reviewed-by/Tested-by tags when posting new
versions, under or above your Signed-off-by tag. Tag is "received", when
provided in a message replied to you on the mailing list. Tools like b4
can help here. However, there's no need to repost patches *only* to add
the tags. The upstream maintainer will do that for tags received on the
version they apply.

https://elixir.bootlin.com/linux/v6.5-rc3/source/Documentation/process/submitting-patches.rst#L577

If a tag was not added on purpose, please state why and what changed.

Best regards,
Krzysztof

Powered by blists - more mailing lists