linux-kernel - Re: [PATCH v13 1/3] dt-bindings: adc: add AD7173

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Wed, 21 Feb 2024 10:29:30 +0200
From: Ceclan Dumitru <mitrutzceclan@...il.com>
To: David Lechner <dlechner@...libre.com>
Cc: linus.walleij@...aro.org, brgl@...ev.pl, andy@...nel.org,
 linux-gpio@...r.kernel.org, Lars-Peter Clausen <lars@...afoo.de>,
 Jonathan Cameron <jic23@...nel.org>, Rob Herring <robh+dt@...nel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
 Conor Dooley <conor+dt@...nel.org>, Michael Walle <michael@...le.cc>,
 Andy Shevchenko <andy.shevchenko@...il.com>, Arnd Bergmann <arnd@...db.de>,
 ChiaEn Wu <chiaen_wu@...htek.com>, Niklas Schnelle <schnelle@...ux.ibm.com>,
 Leonard Göhrs <l.goehrs@...gutronix.de>,
 Mike Looijmans <mike.looijmans@...ic.nl>, Haibo Chen <haibo.chen@....com>,
 Hugo Villeneuve <hvilleneuve@...onoff.com>,
 Ceclan Dumitru <dumitru.ceclan@...log.com>, linux-iio@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v13 1/3] dt-bindings: adc: add AD7173



On 2/20/24 22:54, David Lechner wrote:
> On Tue, Feb 20, 2024 at 3:43 AM Dumitru Ceclan <mitrutzceclan@...il.com> wrote:

..

>> +  clocks:
>> +    maxItems: 1
>> +    description: |
> 
> Don't need `|` here.
> 
The description contains ": ". Without '|' yaml syntax considers the
whole string before ':' as another attribute

>> +      Optional external clock source. Can include one clock source: external
>> +      clock or external crystal.
>> +

..

>> +
>> +      diff-channels:
>> +        items:
>> +          minimum: 0
>> +          maximum: 31
>> +
> 
> Are we missing `bipolar: true` here? (since we have
> unevaluatedProperties: false)
> 

No, since we are referencing the adc schema "$ref: adc.yaml"
Which contains:
"""
  bipolar:

    $ref: /schemas/types.yaml#/definitions/flag

    description: If provided, the channel is to be used in bipolar mode.
"""


..

>> +
>> +required:
>> +  - compatible
>> +  - reg
> 
> Aren't the various power supplies supposed to be required?
> 
> - avdd-supply
> - avdd2-supply
> - iovdd-supply

>From my point of view, if someone uses a single supply (avdd == avdd2 ==
iovdd), and uses only the internal reference then the supplies should
not necessarily be required.