linux-kernel - Re: [PATCH] scsi: ufs: core: Fix mcq mac configuration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2e21a0fb608858b2492808ee35da2c335ce4c0c0.camel@mediatek.com>
Date: Wed, 21 Feb 2024 08:50:12 +0000
From: Peter Wang (王信友) <peter.wang@...iatek.com>
To: "quic_cang@...cinc.com" <quic_cang@...cinc.com>, "beanhuo@...ron.com"
	<beanhuo@...ron.com>, "rohitner@...gle.com" <rohitner@...gle.com>,
	"bvanassche@....org" <bvanassche@....org>, "martin.petersen@...cle.com"
	<martin.petersen@...cle.com>
CC: "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
	"avri.altman@....com" <avri.altman@....com>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "quic_nguyenb@...cinc.com"
	<quic_nguyenb@...cinc.com>, CC Chou (周志杰)
	<cc.chou@...iatek.com>, Ed Tsai (蔡宗軒)
	<Ed.Tsai@...iatek.com>, Chun-Hung Wu (巫駿宏)
	<Chun-hung.Wu@...iatek.com>
Subject: Re: [PATCH] scsi: ufs: core: Fix mcq mac configuration

On Tue, 2024-02-20 at 01:56 -0800, Rohit Ner wrote:
> As per JEDEC Standard No. 223E Section 5.9.2,
> the max # active commands value programmed by the host sw
> in MCQConfig.MAC should be one less than the actual value.
> 
> Signed-off-by: Rohit Ner <rohitner@...gle.com>
> ---
>  drivers/ufs/core/ufs-mcq.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/ufs/core/ufs-mcq.c b/drivers/ufs/core/ufs-mcq.c
> index 0787456c2b89..c873fd823942 100644
> --- a/drivers/ufs/core/ufs-mcq.c
> +++ b/drivers/ufs/core/ufs-mcq.c
> @@ -94,7 +94,7 @@ void ufshcd_mcq_config_mac(struct ufs_hba *hba, u32
> max_active_cmds)
>  
>  	val = ufshcd_readl(hba, REG_UFS_MCQ_CFG);
>  	val &= ~MCQ_CFG_MAC_MASK;
> -	val |= FIELD_PREP(MCQ_CFG_MAC_MASK, max_active_cmds);
> +	val |= FIELD_PREP(MCQ_CFG_MAC_MASK, max_active_cmds - 1);
>  	ufshcd_writel(hba, val, REG_UFS_MCQ_CFG);
>  }
>  EXPORT_SYMBOL_GPL(ufshcd_mcq_config_mac);


Meidatek host controller MAC_SUPP_MAC setting is 64, which 
should config to 0x3F.


Reviewed-by: Peter Wang <peter.wang@...iatek.com>